Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
Date	2017-03-22 19:50 +0100
Message-ID	<tnTuy-6TD-31@gated-at.bofh.it> (permalink)
References	<tnMjn-1pY-3@gated-at.bofh.it> <tnTkR-6PF-5@gated-at.bofh.it> <tnTkT-6PF-29@gated-at.bofh.it> <tnTux-6TD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 11:44:21AM -0700, Dmitry Torokhov wrote:
> On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
> > On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> > > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> > >> From: Jagan Teki <jagan@amarulasolutions.com>
> > >>
> > >> Added missing of_match_table for max11801_ts driver with
> > >> compatible as "maxim,max11801_ts"
> > >>
> > >
> > > Why not "maxim,max11801"? Also, I think we'd need a binding document.
> > 
> > Compatibility purpose to make this is for touchscreen and few of other
> 
> Compatibility with what? The i2c id is "max11801" (without the "-ts").

Now that I looked at your 2/3 and 3/3 patches you use:

+&i2c1 {
+       max11801: touchscreen@48 {
+               compatible = "maxim,max11801";
+               reg = <0x48>;
+               interrupt-parent = <&gpio3>;
+               interrupts = <31 2>;
+       };
+};

so the compatible you are adding to the driver is definitely wrong.

By the way, it would be nice if you used symbolic constants to express
interrupt trigger type.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki <jagan@openedev.com> - 2017-03-22 12:10 +0100
  [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki <jagan@openedev.com> - 2017-03-22 12:20 +0100
  Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-22 19:40 +0100
    Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki <jagan@amarulasolutions.com> - 2017-03-22 19:40 +0100
      Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-22 19:50 +0100
        Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki <jagan@amarulasolutions.com> - 2017-03-22 19:50 +0100
        Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-22 19:50 +0100

csiph-web