Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer
Date	2017-03-22 19:20 +0100
Message-ID	<tnT1w-6Ex-5@gated-at.bofh.it> (permalink)
References	<tnfnr-3z0-7@gated-at.bofh.it> <tnfnr-3z0-11@gated-at.bofh.it> <tnJOx-7TA-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 09:26:41AM +0100, Heiko Stuebner wrote:
> Am Montag, 20. März 2017, 16:53:44 CET schrieb Brian Norris:
> > We need to enable this regulator before the digitizer can be used. Wacom
> > recommended waiting for 100 ms before talking to the HID.
> > 
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > ---
> > v3:
> >  * reintroduced into patch set; bindings are in linux-next
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index
> > 2f720cf2fd07..f4714c4606f3 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> > @@ -232,6 +232,9 @@ ap_i2c_dig: &i2c2 {
> 
> according to the hid-over-i2c binding, this should use a special compatible 
> like
> 
> 	compatible = "wacom,w9013", "hid-over-i2c"
> 
> As the binding patch is from Caesar, I assume that is the Kevin component and
> I can add that myself, just need confirmation that this is actually the correct 
> component :-) .

*Sigh.* The I2C (and SPI) framework is still broken w.r.t. multiple
compatible strings and drivers built as modules [1]. So I'd really
rather not do this...

...but yes, that's a fair component description.

Brian

[1] Some discussion about SPI:
    https://patchwork.kernel.org/patch/7630571/
    And the discussion about I2C (25% through that thread):
    https://patchwork.kernel.org/patch/9455245/

Thread

[PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Brian Norris <briannorris@chromium.org> - 2017-03-21 01:00 +0100
  Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Heiko Stuebner <heiko@sntech.de> - 2017-03-22 09:30 +0100
    Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for  Kevin digitizer Brian Norris <briannorris@chromium.org> - 2017-03-22 19:20 +0100
      Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Heiko Stuebner <heiko@sntech.de> - 2017-03-23 01:00 +0100

csiph-web