Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606833

Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver

From Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver
Date 2017-03-22 18:50 +0100
Message-ID <tnSyu-6bg-43@gated-at.bofh.it> (permalink)
References <tkXEl-2LN-3@gated-at.bofh.it> <tkXEm-2LN-15@gated-at.bofh.it> <tnnuF-JD-3@gated-at.bofh.it> <tnSyu-6bg-45@gated-at.bofh.it> <tnnuF-JD-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote:
> Hi,
> 
> On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote:
> > Add Palmchip BK3710 PATA controller driver.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> There are some checkpatch suggestions that are worth fixing, I think.
> 
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:277: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:320: CHECK: Alignment should match open parenthesis
> [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 2206.eml:489: CHECK: Comparison to NULL could be written "!mem"

Will be fixed in v3, thanks.

[ My scripts didn't run checkpatch with --strict so I haven't noticed them. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 17:40 +0100
  [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 17:40 +0100
    Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-18 19:10 +0100
      Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 19:00 +0100
    Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Sekhar Nori <nsekhar@ti.com> - 2017-03-21 09:40 +0100
      Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-22 18:50 +0100
        Re: [PATCH v2 1/3] ata: add Palmchip BK3710 PATA controller driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-22 19:00 +0100
  Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Tejun Heo <tj@kernel.org> - 2017-03-16 23:10 +0100
    Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Sekhar Nori <nsekhar@ti.com> - 2017-03-21 09:40 +0100
      Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Tejun Heo <tj@kernel.org> - 2017-03-21 18:00 +0100
  Re: [PATCH v2 0/3] ATA/ARM: convert ARM/DaVinci to use libata PATA  drivers Sekhar Nori <nsekhar@ti.com> - 2017-03-21 09:50 +0100

csiph-web