Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606763
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 06/23] scsi: hisi_sas: error hisi_sas_task_prep() when port down |
| Date | 2017-03-22 18:10 +0100 |
| Message-ID | <tnRVL-5RD-9@gated-at.bofh.it> (permalink) |
| References | <tnRM5-5ys-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
When sas_port is NULL, then return SAS_PHY_DOWN.
In addition, when the sas_dev is gone then explicitly
return SAS_PHY_DOWN.
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f64c1b6..7c1fb75 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -200,7 +200,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
*/
if (device->dev_type != SAS_SATA_DEV)
task->task_done(task);
- return 0;
+ return SAS_PHY_DOWN;
}
if (DEV_IS_GONE(sas_dev)) {
@@ -211,8 +211,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
dev_info(dev, "task prep: device %016llx not ready\n",
SAS_ADDR(device->sas_addr));
- rc = SAS_PHY_DOWN;
- return rc;
+ return SAS_PHY_DOWN;
}
port = to_hisi_sas_port(sas_port);
--
1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/23] hisi_sas: error handling and other misc fixes and improvements John Garry <john.garry@huawei.com> - 2017-03-22 18:00 +0100 [PATCH 13/23] scsi: hisi_sas: fix some sas_task.task_state_lock locking John Garry <john.garry@huawei.com> - 2017-03-22 18:00 +0100 [PATCH 12/23] scsi: hisi_sas: free slots after hardreset John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 10/23] scsi: hisi_sas: hardreset for SATA disk in LU reset John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 09/23] scsi: hisi_sas: modify hisi_sas_abort_task() for SSP John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 14/23] scsi: hisi_sas: remove task free'ing for timeouts John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 06/23] scsi: hisi_sas: error hisi_sas_task_prep() when port down John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 15/23] scsi: hisi_sas: process error codes according to their priority John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 02/23] scsi: hisi_sas: add controller reset John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 19/23] scsi: hisi_sas: add hisi_sas_clear_nexus_ha() John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 22/23] scsi: hisi_sas: use dev_is_sata to identify SATA or SAS disk John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 17/23] scsi: hisi_sas: handle PHY UP+DOWN simultaneous irq John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 05/23] scsi: hisi_sas: remove hisi_sas_port_deformed() John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 16/23] scsi: hisi_sas: some modifications to v2 hw reg init values John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 04/23] scsi: hisi_sas: add softreset function for SATA disk John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 20/23] scsi: hisi_sas: release SMP slot in lldd_abort_task John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 [PATCH 03/23] scsi: hisi_sas: move PHY init to hisi_sas_scan_start() John Garry <john.garry@huawei.com> - 2017-03-22 18:10 +0100 Re: [PATCH 00/23] hisi_sas: error handling and other misc fixes and improvements "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-23 16:20 +0100
csiph-web