Re: [2/2] zd1211rw: fix NULL-deref at probe

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [2/2] zd1211rw: fix NULL-deref at probe
Date	2017-03-22 14:10 +0100
Message-ID	<tnObw-2PV-19@gated-at.bofh.it> (permalink)
References	<tkxAe-ys-41@gated-at.bofh.it> <tnKrf-8tF-9@gated-at.bofh.it> <tnNS9-2sZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Johan Hovold <johan@kernel.org> writes:

> On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote:
>> Johan Hovold <johan@kernel.org> wrote:
>> > Make sure to check the number of endpoints to avoid dereferencing a
>> > NULL-pointer or accessing memory beyond the endpoint array should a
>> > malicious device lack the expected endpoints.
>> > 
>> > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM
>> > device into WLAN device")
>> > Cc: Daniel Drake <dsd@gentoo.org>
>> > Signed-off-by: Johan Hovold <johan@kernel.org>
>> 
>> Patch applied to wireless-drivers-next.git, thanks.
>> 
>> ca260ece6a57 zd1211rw: fix NULL-deref at probe
>
> What about patch 1/2 which fixes the same bug (literally copied from the
> zd1211rw driver)?

I will apply that to my separate ath.git tree, just didn't get to your
patch yet.

> And as these fixes should be backported to stable (I left out the tag
> for networking drivers)

Actually for wireless drivers you should add the stable tag.

> why only apply to -next?

I didn't see that the fix was important enough for 4.11.

-- 
Kalle Valo

Thread

Re: [2/2] zd1211rw: fix NULL-deref at probe Kalle Valo <kvalo@codeaurora.org> - 2017-03-22 10:10 +0100
  Re: [2/2] zd1211rw: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-03-22 13:50 +0100
    Re: [2/2] zd1211rw: fix NULL-deref at probe Kalle Valo <kvalo@codeaurora.org> - 2017-03-22 14:10 +0100
      Re: [2/2] zd1211rw: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-03-22 14:30 +0100

csiph-web