Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606425

Re: [PATCH v2] sched/deadline: Make find_later_rq() choose a closer cpu in topology

Show all headers | View raw

On Tue, Mar 21, 2017 at 04:52:24PM +0900, Byungchul Park wrote:
> When cpudl_find() returns any among free_cpus, the cpu might not be
> closer than others, considering sched domain. For example:
> 
>    this_cpu: 15
>    free_cpus: 0, 1,..., 14 (== later_mask)
>    best_cpu: 0
> 
>    topology:
> 
>    0 --+
>        +--+
>    1 --+  |
>           +-- ... --+
>    2 --+  |         |
>        +--+         |
>    3 --+            |
> 
>    ...             ...
> 
>    12 --+           |
>         +--+        |
>    13 --+  |        |
>            +-- ... -+
>    14 --+  |
>         +--+
>    15 --+
> 
> In this case, it would be best to select 14 since it's a free cpu and
> closest to 15(this_cpu). However, currently the code select 0(best_cpu)
> even though that's just any among free_cpus. Fix it.

This would result in picking the HT sibling, if available. Which is
typically the worst possible pick.

If you add support for SD_PREFER_SIBLING, which denotes a preference for
any other sibling domain above this one, this might work.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] sched/deadline: Make find_later_rq() choose a closer cpu in topology Byungchul Park <byungchul.park@lge.com> - 2017-03-21 09:00 +0100
  Re: [PATCH v2] sched/deadline: Make find_later_rq() choose a closer  cpu in topology Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-03-21 14:30 +0100
    Re: [PATCH v2] sched/deadline: Make find_later_rq() choose a closer  cpu in topology Byungchul Park <byungchul.park@lge.com> - 2017-03-22 03:50 +0100
  Re: [PATCH v2] sched/deadline: Make find_later_rq() choose a closer  cpu in topology Peter Zijlstra <peterz@infradead.org> - 2017-03-22 13:40 +0100
    Re: [PATCH v2] sched/deadline: Make find_later_rq() choose a closer  cpu in topology Byungchul Park <byungchul.park@lge.com> - 2017-03-23 00:30 +0100

csiph-web