Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606281
| From | Lionel DEBIEVE <lionel.debieve@st.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware |
| Date | 2017-03-22 09:50 +0100 |
| Message-ID | <tnK7T-81a-7@gated-at.bofh.it> (permalink) |
| References | <tnuw9-5FD-11@gated-at.bofh.it> <tnx10-7bE-5@gated-at.bofh.it> <tnxaG-7fa-3@gated-at.bofh.it> <tnyq6-8is-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner <tglx@linutronix.de> wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: >>>> /* >>>> * Disable interrupts so we don't get the IRQ line >>>> bouncing >>> I'm nervous about the above comment, which in full is: >>> >>> /* >>> * Disable interrupts so we don't get the IRQ line bouncing >>> * up and down while interrupts are disabled. >>> */ >>> >>> I'm not sure if disabling interrupts helps on an SMP system. This >>> patch does change what happens when port->sysrq is set. But I'm not >>> sure we care. >> It disables interrupts at the device level which obviously helps >> whether on SMP or not. >> > OK, so this has nothing to do with the local_irq_save() that is being > removed, which would be fine then. > > > -- Steve >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RT] tty: serial: st-asc: Make the locking RT aware <lionel.debieve@st.com> - 2017-03-21 17:10 +0100
Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Steven Rostedt <rostedt@goodmis.org> - 2017-03-21 19:50 +0100
Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Thomas Gleixner <tglx@linutronix.de> - 2017-03-21 20:00 +0100
Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Steven Rostedt <rostedt@goodmis.org> - 2017-03-21 21:20 +0100
Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Lionel DEBIEVE <lionel.debieve@st.com> - 2017-03-22 09:50 +0100
RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Lionel DEBIEVE <lionel.debieve@st.com> - 2017-03-22 17:20 +0100
Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware Steven Rostedt <rostedt@goodmis.org> - 2017-03-22 17:20 +0100
csiph-web