Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c

From	Gautham R Shenoy <ego@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c
Date	2017-03-22 06:50 +0100
Message-ID	<tnHjI-5ZR-7@gated-at.bofh.it> (permalink)
References	<tn7SV-6Ou-11@gated-at.bofh.it> <tn7SV-6Ou-9@gated-at.bofh.it> <tn8vE-7pZ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Nick,

On Tue, Mar 21, 2017 at 02:35:17AM +1000, Nicholas Piggin wrote:
> On Mon, 20 Mar 2017 21:24:15 +0530
> "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> wrote:
> 
> > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
> > 
> > Move the piece of code in powernv/smp.c::pnv_smp_cpu_kill_self() which
> > transitions the CPU to the deepest available platform idle state to a
> > new function named pnv_cpu_offline() in powernv/idle.c. The rationale
> > behind this code movement is that the data required to determine the
> > deepest available platform state resides in powernv/idle.c.
> > 
> > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> 
> Looks good. As a nitpick, possibly one or two variables in idle.c could
> become static (pnv_deepest_stop_psscr_*).
>

I changed that, but it ended up being in the next patch.

> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> 

Thanks!

--
Thanks and Regards
gautham.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation from smp.c to idle.c "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-20 17:00 +0100
  Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation  from smp.c to idle.c Nicholas Piggin <npiggin@gmail.com> - 2017-03-20 17:40 +0100
    Re: [v2 PATCH 1/4] powernv: Move CPU-Offline idle state invocation  from smp.c to idle.c Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-03-22 06:50 +0100

csiph-web