Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606211
| From | Vinay Simha B N <simhavcs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required |
| Date | 2017-03-22 06:20 +0100 |
| Message-ID | <tnGQF-5L3-3@gated-at.bofh.it> (permalink) |
| References | <tkNbY-3N3-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
hi,
Could you please give some feedback or review comments for this patch
On 3/14/17, Vinay Simha BN <simhavcs@gmail.com> wrote:
> 4 macros already defined in hdmi.h,
> which is not required to redefine in hdmi_audio.c
>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> index a54d3bb..8177e85 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
> @@ -18,13 +18,6 @@
> #include <linux/hdmi.h>
> #include "hdmi.h"
>
> -
> -/* Supported HDMI Audio channels */
> -#define MSM_HDMI_AUDIO_CHANNEL_2 0
> -#define MSM_HDMI_AUDIO_CHANNEL_4 1
> -#define MSM_HDMI_AUDIO_CHANNEL_6 2
> -#define MSM_HDMI_AUDIO_CHANNEL_8 3
> -
> /* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of
> channels: */
> static int nchannels[] = { 2, 4, 6, 8 };
>
> --
> 2.7.4
>
>
--
regards,
vinaysimha
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/msm/hdmi: redefinitions of macros not required Vinay Simha BN <simhavcs@gmail.com> - 2017-03-14 06:30 +0100
Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required Vinay Simha B N <simhavcs@gmail.com> - 2017-03-22 06:20 +0100
Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required Rob Clark <robdclark@gmail.com> - 2017-03-22 12:20 +0100
csiph-web