Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606172
| From | Xie XiuQi <xiexiuqi@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V13 09/10] trace, ras: add ARM processor error trace event |
| Date | 2017-03-22 04:00 +0100 |
| Message-ID | <tnEFb-40q-1@gated-at.bofh.it> (permalink) |
| References | <tnALf-1nk-1@gated-at.bofh.it> <tnALf-1nk-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Reviewed-by: Xie XiuQi <xiexiuqi@huawei.com>
On 2017/3/22 6:47, Tyler Baicar wrote:
> Currently there are trace events for the various RAS
> errors with the exception of ARM processor type errors.
> Add a new trace event for such errors so that the user
> will know when they occur. These trace events are
> consistent with the ARM processor error section type
> defined in UEFI 2.6 spec section N.2.4.4.
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> drivers/acpi/apei/ghes.c | 8 +++++++-
> drivers/firmware/efi/cper.c | 1 +
> drivers/ras/ras.c | 1 +
> include/ras/ras_event.h | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 3ecbacc..230b095 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -515,7 +515,13 @@ static void ghes_do_proc(struct ghes *ghes,
> }
> #endif
> #ifdef CONFIG_RAS
> - else if (trace_unknown_sec_event_enabled()) {
> + else if (!uuid_le_cmp(sec_type, CPER_SEC_PROC_ARM) &&
> + trace_arm_event_enabled()) {
> + struct cper_sec_proc_arm *arm_err;
> +
> + arm_err = acpi_hest_generic_data_payload(gdata);
> + trace_arm_event(arm_err);
> + } else if (trace_unknown_sec_event_enabled()) {
> void *unknown_err = acpi_hest_generic_data_payload(gdata);
> trace_unknown_sec_event(&sec_type,
> fru_id, fru_text, sec_sev,
> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index d263bc8..37a39af 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -35,6 +35,7 @@
> #include <linux/printk.h>
> #include <linux/bcd.h>
> #include <acpi/ghes.h>
> +#include <ras/ras_event.h>
>
> #define INDENT_SP " "
>
> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c
> index fb2500b..8ba5a94 100644
> --- a/drivers/ras/ras.c
> +++ b/drivers/ras/ras.c
> @@ -28,3 +28,4 @@ static int __init ras_init(void)
> #endif
> EXPORT_TRACEPOINT_SYMBOL_GPL(mc_event);
> EXPORT_TRACEPOINT_SYMBOL_GPL(unknown_sec_event);
> +EXPORT_TRACEPOINT_SYMBOL_GPL(arm_event);
> diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
> index 5861b6f..13befad 100644
> --- a/include/ras/ras_event.h
> +++ b/include/ras/ras_event.h
> @@ -162,6 +162,51 @@
> );
>
> /*
> + * ARM Processor Events Report
> + *
> + * This event is generated when hardware detects an ARM processor error
> + * has occurred. UEFI 2.6 spec section N.2.4.4.
> + */
> +TRACE_EVENT(arm_event,
> +
> + TP_PROTO(const struct cper_sec_proc_arm *proc),
> +
> + TP_ARGS(proc),
> +
> + TP_STRUCT__entry(
> + __field(u64, mpidr)
> + __field(u64, midr)
> + __field(u32, running_state)
> + __field(u32, psci_state)
> + __field(u8, affinity)
> + ),
> +
> + TP_fast_assign(
> + if (proc->validation_bits & CPER_ARM_VALID_AFFINITY_LEVEL)
> + __entry->affinity = proc->affinity_level;
> + else
> + __entry->affinity = ~0;
> + if (proc->validation_bits & CPER_ARM_VALID_MPIDR)
> + __entry->mpidr = proc->mpidr;
> + else
> + __entry->mpidr = 0ULL;
> + __entry->midr = proc->midr;
> + if (proc->validation_bits & CPER_ARM_VALID_RUNNING_STATE) {
> + __entry->running_state = proc->running_state;
> + __entry->psci_state = proc->psci_state;
> + } else {
> + __entry->running_state = ~0;
> + __entry->psci_state = ~0;
> + }
> + ),
> +
> + TP_printk("affinity level: %d; MPIDR: %016llx; MIDR: %016llx; "
> + "running state: %d; PSCI state: %d",
> + __entry->affinity, __entry->mpidr, __entry->midr,
> + __entry->running_state, __entry->psci_state)
> +);
> +
> +/*
> * Unknown Section Report
> *
> * This event is generated when hardware detected a hardware
>
--
Thanks,
Xie XiuQi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V13 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 09/10] trace, ras: add ARM processor error trace event Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
Re: [PATCH V13 09/10] trace, ras: add ARM processor error trace event Xie XiuQi <xiexiuqi@huawei.com> - 2017-03-22 04:00 +0100
Re: [PATCH V13 09/10] trace, ras: add ARM processor error trace event "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-03-22 04:10 +0100
[PATCH V13 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1 Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 08/10] ras: acpi / apei: generate trace event for unrecognized CPER section Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 10/10] arm/arm64: KVM: add guest SEA support Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
Re: [PATCH V13 10/10] arm/arm64: KVM: add guest SEA support Catalin Marinas <catalin.marinas@arm.com> - 2017-03-23 19:00 +0100
Re: [PATCH V13 10/10] arm/arm64: KVM: add guest SEA support Marc Zyngier <marc.zyngier@arm.com> - 2017-03-24 15:10 +0100
Re: [PATCH V13 10/10] arm/arm64: KVM: add guest SEA support Christoffer Dall <cdall@linaro.org> - 2017-03-24 17:10 +0100
[PATCH V13 04/10] arm64: exception: handle Synchronous External Abort Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
Re: [PATCH V13 04/10] arm64: exception: handle Synchronous External Abort Catalin Marinas <catalin.marinas@arm.com> - 2017-03-23 18:10 +0100
[PATCH V13 07/10] efi: print unrecognized CPER section Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 05/10] acpi: apei: handle SEA notification type for ARMv8 Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
Re: [PATCH V13 05/10] acpi: apei: handle SEA notification type for ARMv8 Catalin Marinas <catalin.marinas@arm.com> - 2017-03-23 19:00 +0100
[PATCH V13 01/10] acpi: apei: read ack upon ghes record consumption Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 06/10] acpi: apei: panic OS with fatal error status block Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-21 23:50 +0100
[PATCH V13 03/10] efi: parse ARM processor error Tyler Baicar <tbaicar@codeaurora.org> - 2017-03-22 00:00 +0100
csiph-web