Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604818

Re: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

Show all headers | View raw

Brian Norris <briannorris@chromium.org> wrote:
> We shouldn't be printing a kernel pointer as a decimal integer. But we
> really shouldn't be printing this case at all; we should never get here
> with NULL drvdata. We've eliminated this unnecessary conditional in
> several other places, so kill it here too.
> 
> Similarly, there's no need to check for '!pdev'; we are guaranteed to
> have a real device here.
> 
> And finally, use dev_err() instead of pr_err().
> 
> This yields (for failed PCIe resets):
> 
> [   68.286586] mwifiex_pcie 0000:01:00.0: mwifiex_pcie_reset_notify: adapter structure is not valid
> 
> instead of:
> 
> [   82.932658] mwifiex_pcie: mwifiex_pcie_reset_notify: Card or adapter structure is not valid (-270880688088)
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

520334156213 mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

-- 
https://patchwork.kernel.org/patch/9609861/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: mwifiex: pcie: clean up error prints in  mwifiex_pcie_reset_notify() Kalle Valo <kvalo@codeaurora.org> - 2017-03-20 18:20 +0100

csiph-web