Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604737

Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

Show all headers | View raw

On Fri, Mar 17, 2017 at 3:11 PM, Moritz Fischer <mdf@kernel.org> wrote:

Hi Moritz,

Minor nits below.  Otherwise, looks good.

> This adds the binding documentation for the Xilinx LogiCORE PR
> Decoupler soft core.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: devicetree@vger.kernel.org

Acked-by: Alan Tull <atull@kernel.org>

> ---
>
> Changes from v2:
> - Added refence to generic fpga-region bindings
> - Fixed up reg property in example
> - Added fallback to "xlnx,pr-decoupler" without version
>
> Changes from v1:
> - Added clock names & clock to example
> - Merged some of the description from Michal's version
>
> ---
>  .../bindings/fpga/xilinx-pr-decoupler.txt          | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
>
> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> new file mode 100644
> index 0000000..16141bd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> @@ -0,0 +1,35 @@
> +Xilinx LogiCORE Partial Reconfig Decoupler Softcore
> +
> +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more
> +decouplers / fpga bridges.
> +The controller can decouple/disable the bridges which prevents signal
> +changes from passing through the bridge.  The controller can also
> +couple / enable the bridges which allows traffic to pass through the
> +bridge normally.
> +
> +The Driver supports only MMIO handling. A PR region can have multiple
> +PR Decouples which can bhe handled independently or chaines via decouple/

s/PR Decoupler/PR Decouplers/
s/bhe/be/
s/chaines/chained/

> +decouple_status signals.
> +
> +Required properties:
> +- compatible           : Should contain "xlnx,pr-decoupler-1.00"
> +- regs                 : base address and size for decoupler module
> +- clocks               : input clock to IP
> +- clock-names          : should contain "aclk"
> +
> +Optional properties:
> +- bridge-enable                : 0 if driver should disable bridge at startup
> +                         1 if driver should enable bridge at startup
> +                         Default is to leave bridge in current state.
> +
> +See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
> +
> +Example:
> +       fpga-bridge@100000450 {
> +               compatible = "xlnx,pr-decoupler-1.00",
> +                            "xlnx-pr-decoupler";
> +               regs = <0x10000045 0x10>;
> +               clocks = <&clkc 15>;
> +               clock-names = "aclk";
> +               bridge-enable = <0>;
> +       };
> --
> 2.7.4
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Moritz Fischer <mdf@kernel.org> - 2017-03-17 21:20 +0100
  [PATCH v3 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler Moritz Fischer <mdf@kernel.org> - 2017-03-17 21:20 +0100
    Re: [PATCH v3 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler Alan Tull <delicious.quinoa@gmail.com> - 2017-03-20 17:30 +0100
    Re: [PATCH v3 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler kbuild test robot <lkp@intel.com> - 2017-03-20 18:00 +0100
  Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Alan Tull <delicious.quinoa@gmail.com> - 2017-03-20 17:20 +0100
  Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR  Decoupler Rob Herring <robh@kernel.org> - 2017-03-24 16:10 +0100
    Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR  Decoupler Moritz Fischer <moritz.fischer.private@gmail.com> - 2017-03-24 16:30 +0100
      Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Alan Tull <delicious.quinoa@gmail.com> - 2017-03-24 18:40 +0100
        Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR  Decoupler Moritz Fischer <moritz.fischer.private@gmail.com> - 2017-03-24 19:10 +0100

csiph-web