Re: [PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller
Date	2017-03-20 15:30 +0100
Message-ID	<tn6tR-5Wi-47@gated-at.bofh.it> (permalink)
References	<tmtVv-3Pb-7@gated-at.bofh.it> <tmtVv-3Pb-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 18, 2017 at 05:09:27PM -0400, Steven Rostedt wrote:
> @@ -111,12 +114,11 @@ GLOBAL(ftrace_regs_call)
>  	popl	%es
>  	popl	%fs
>  	popl	%gs
> -	addl	$8, %esp			/* Skip orig_ax and ip */
> -	popf					/* Pop flags at end (no addl to corrupt flags) */
> -	jmp	.Lftrace_ret
>  
> -	popf
> -	jmp	ftrace_stub
> +	/* use lea to not affect flags */
> +	lea	3*4(%esp), %esp			/* Skip orig_ax, ip and flags */
> +
> +	jmp	.Lftrace_ret
>  #else /* ! CONFIG_DYNAMIC_FTRACE */
>  
>  ENTRY(mcount)

That last comment should be

  /* Skip orig_ax, ip and cs */

Otherwise:

  Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller Steven Rostedt <rostedt@goodmis.org> - 2017-03-18 22:20 +0100
  Re: [PATCH 4/6 v3] ftrace/x86_32: Clean up ftrace_regs_caller Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-20 15:30 +0100

csiph-web