Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1604632

Re: [PATCH] clk: tegra: fix disable unused for clocks sharing enable bit

From Peter De Schrijver <pdeschrijver@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: tegra: fix disable unused for clocks sharing enable bit
Date 2017-03-20 15:30 +0100
Message-ID <tn6tQ-5Wi-25@gated-at.bofh.it> (permalink)
References <tlhWp-lx-5@gated-at.bofh.it> <tn5Hs-5ly-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Mar 20, 2017 at 02:27:46PM +0100, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Wed, Mar 15, 2017 at 04:10:54PM +0200, Peter De Schrijver wrote:
> > In case 2 clocks share an enable bit and one of them is enabled by a driver
> > and the other one is not, CCF will think it's enabled because it will only
> > look at the hw state. Therefor it will disable the clock and thus also
> > disable the other clock which was enabled. Solve this by reading the
> > initial state of the enable bit and incrementing the refcount if it's set.
> > 
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> >  drivers/clk/tegra/clk-periph-gate.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> I think you had already sent a version of this patch a couple of weeks
> ago. I've applied the first version since I couldn't spot any delta
> between them.

Hmm. Could be.

Cheers,

Peter.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] clk: tegra: fix disable unused for clocks sharing enable bit Peter De Schrijver <pdeschrijver@nvidia.com> - 2017-03-15 15:20 +0100
  Re: [PATCH] clk: tegra: fix disable unused for clocks sharing enable  bit Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 14:40 +0100
    Re: [PATCH] clk: tegra: fix disable unused for clocks sharing enable  bit Peter De Schrijver <pdeschrijver@nvidia.com> - 2017-03-20 15:30 +0100

csiph-web