[PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'
Date	2017-03-20 15:30 +0100
Message-ID	<tn6tP-5Wi-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

Currently, if pservice is null then service is set to NULL and immediately
afterwards service is dereferenced causing a null pointer dereference. Fix
this by bailing out early of the function with a null return.

Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index dc9f85c2a5da..4f9e738abddf 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -2673,7 +2673,7 @@ vchiq_add_service_internal(VCHIQ_STATE_T *state,
 
 	if (!pservice) {
 		kfree(service);
-		service = NULL;
+		return NULL;
 	}
 
 	service_quota = &state->service_quotas[service->localport];
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service' Colin King <colin.king@canonical.com> - 2017-03-20 15:30 +0100
  Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on  pointer 'service' Stefan Wahren <stefan.wahren@i2se.com> - 2017-03-20 15:50 +0100

csiph-web