Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604625
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error |
| Date | 2017-03-20 15:30 +0100 |
| Message-ID | <tn6tP-5Wi-17@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
From: Colin Ian King <colin.king@canonical.com>
The comparison of an out of range index into space->context_tbl is
off-by-one and should be using >= rather than > in the comparison.
Detected by CoverityScan, CID#1419694 ("Out-of-bounds read")
Fixes: 849246e7ce9ce ("tpm2: add session handle context saving and restoring to the space code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/tpm/tpm2-space.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c
index d36d81e07076..009934269514 100644
--- a/drivers/char/tpm/tpm2-space.c
+++ b/drivers/char/tpm/tpm2-space.c
@@ -229,7 +229,7 @@ static bool tpm2_map_to_phandle(struct tpm_space *space, void *handle)
int i;
i = 0xFFFFFF - (vhandle & 0xFFFFFF);
- if (i > ARRAY_SIZE(space->context_tbl) || !space->context_tbl[i])
+ if (i >= ARRAY_SIZE(space->context_tbl) || !space->context_tbl[i])
return false;
phandle = space->context_tbl[i];
--
2.11.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Colin King <colin.king@canonical.com> - 2017-03-20 15:30 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Colin Ian King <colin.king@canonical.com> - 2017-03-22 12:50 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-22 14:20 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-23 17:00 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-23 17:30 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-23 17:50 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-23 19:20 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-23 17:00 +0100
Re: [PATCH] tpm2: fix off-by-one comparison and out-of-bounds read error Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-22 12:50 +0100
csiph-web