Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings
Date	2017-03-20 14:30 +0100
Message-ID	<tn5xL-5ik-1@gated-at.bofh.it> (permalink)
References	<tmB6F-oy-3@gated-at.bofh.it> <tn118-27Q-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Mon, Mar 20, 2017 at 4:29 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Florian,
>
> On Sat, Mar 18, 2017 at 09:53:20PM -0700, Florian Fainelli wrote:
>> The CPU port of the BCM53125 is configured with RGMII (no delays) but
>> this should actually be RGMII with transmit delay (rgmii-txid) because
>> STMMAC takes care of inserting the transmitter delay. This fixes
>> occasional packet loss encountered.
>>
>> Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board")
>> Reported-by: Hartmut Knaack <knaack.h@gmx.de>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thanks!
> Maxime

I'm not sure dwmac-sunxi supports "rgmii-txid" though.
At least I don't remember implementing it.

ChenYu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings Florian Fainelli <f.fainelli@gmail.com> - 2017-03-19 06:00 +0100
  Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-03-20 09:40 +0100
    Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings Chen-Yu Tsai <wens@csie.org> - 2017-03-20 14:30 +0100

csiph-web