Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses
Date	2017-03-20 13:20 +0100
Message-ID	<tn4s2-4zk-7@gated-at.bofh.it> (permalink)
References	<tlpTX-5Og-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 15 Mar 2017 23:41:23 +0100,
Matthias Kaehlcke wrote:
> 
> The extra pairs of parantheses are not needed and causes clang to
> generate warnings like this:
> 
> sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
>         if ((buffer == NULL))
>              ~~~~~~~^~~~~~~
> sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning
>         if ((buffer == NULL))
>             ~       ^      ~
> sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment
>         if ((buffer == NULL))
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

Applied, thanks.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: hda/ca0132: Remove double parentheses Matthias Kaehlcke <mka@chromium.org> - 2017-03-15 23:50 +0100
  Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses Takashi Iwai <tiwai@suse.de> - 2017-03-20 13:20 +0100

csiph-web