[PATCH] staging: iio: tsl2x7x_core: Fix standard deviation calculation

From	Eva Rachel Retuya <eraretuya@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: iio: tsl2x7x_core: Fix standard deviation calculation
Date	2017-03-20 12:40 +0100
Message-ID	<tn3Pk-42Z-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Standard deviation is calculated as the square root of the variance
where variance is the mean of sample_sum and length. Correct the
computation of statP->stddev in accordance to the proper calculation.

Fixes: 3c97c08b5735 ("staging: iio: add TAOS tsl2x7x driver")
Reported-by: Abhiram Balasubramanian <abhiram@cs.utah.edu>
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
---
 drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index ea15bc1..197201a 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -854,7 +854,7 @@ void tsl2x7x_prox_calculate(int *data, int length,
 		tmp = data[i] - statP->mean;
 		sample_sum += tmp * tmp;
 	}
-	statP->stddev = int_sqrt((long)sample_sum) / length;
+	statP->stddev = int_sqrt((long)sample_sum / length);
 }
 
 /**
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: tsl2x7x_core: Fix standard deviation calculation Eva Rachel Retuya <eraretuya@gmail.com> - 2017-03-20 12:40 +0100
  Re: [PATCH] staging: iio: tsl2x7x_core: Fix standard deviation  calculation Jonathan Cameron <jic23@kernel.org> - 2017-03-25 17:50 +0100

csiph-web