Re: [alsa-devel] [PATCH 1/1] ALSA: es1688: Use strcpy() instead of sprintf()

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH 1/1] ALSA: es1688: Use strcpy() instead of sprintf()
Date	2017-03-20 12:30 +0100
Message-ID	<tn3FE-3Z3-23@gated-at.bofh.it> (permalink)
References	<tkDZ1-5cJ-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 13 Mar 2017 20:22:50 +0100,
Nicolas Iooss wrote:
> 
> There is no point in using sprintf() without a format string when
> strcpy() can perform the same operation.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Applied, thanks.


Takashi


> ---
>  sound/isa/es1688/es1688_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c
> index e2cf508841b1..81cf26fa28d6 100644
> --- a/sound/isa/es1688/es1688_lib.c
> +++ b/sound/isa/es1688/es1688_lib.c
> @@ -742,7 +742,7 @@ int snd_es1688_pcm(struct snd_card *card, struct snd_es1688 *chip, int device)
>  
>  	pcm->private_data = chip;
>  	pcm->info_flags = SNDRV_PCM_INFO_HALF_DUPLEX;
> -	sprintf(pcm->name, snd_es1688_chip_id(chip));
> +	strcpy(pcm->name, snd_es1688_chip_id(chip));
>  	chip->pcm = pcm;
>  
>  	snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
> -- 
> 2.12.0
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH 1/1] ALSA: es1688: Use strcpy() instead of     sprintf() Takashi Iwai <tiwai@suse.de> - 2017-03-20 12:30 +0100

csiph-web