Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t
Date	2017-03-20 11:50 +0100
Message-ID	<tn32W-3u2-9@gated-at.bofh.it> (permalink)
References	<tm2LE-KO-21@gated-at.bofh.it> <tmpRT-JT-11@gated-at.bofh.it> <tmxZ7-6EK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 18, 2017 at 06:21:21PM -0700, David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Sun, 19 Mar 2017 00:47:59 +0800
> 
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >> On Fri, 2017-03-17 at 07:42 +0000, Reshetova, Elena wrote:
> >> 
> >>> Should we then first measure the actual numbers to understand what we
> >>> are talking here about? 
> >>> I would be glad to do it if you suggest what is the correct way to do
> >>> measurements here to actually reflect the real life use cases. 
> >> 
> >> How have these patches been tested in real life exactly ?
> >> 
> >> Can you quantify number of added cycles per TCP packet, where I expect
> >> we have maybe 20 atomic operations in all layers ...
> > 
> > I completely agree.  I think this thing needs to default to the
> > existing atomic_t behaviour.
> 
> I totally agree as well, the refcount_t facility as-is is unacceptable
> for networking.

Can we at least give a benchmark and have someone run numbers? We should
be able to quantify these things.

Thread

[PATCH 00/17] net subsystem refcount conversions Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:30 +0100
  [PATCH 02/17] net: convert neigh_params.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:30 +0100
  [PATCH 10/17] net: convert in_device.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 12/17] net: convert unix_address.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 14/17] net: convert inet_frag_queue.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 01/17] net: convert neighbour.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 11/17] net: convert netpoll_info.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
    Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-16 18:00 +0100
      Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t Kees Cook <keescook@chromium.org> - 2017-03-16 18:40 +0100
        Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t David Miller <davem@davemloft.net> - 2017-03-16 20:20 +0100
          RE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-03-17 08:50 +0100
            Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-17 17:20 +0100
              Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-18 18:00 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t David Miller <davem@davemloft.net> - 2017-03-19 02:40 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-20 11:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-20 14:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-20 14:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 16:00 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 17:20 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 17:40 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 16:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-20 16:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t Kees Cook <keescook@chromium.org> - 2017-03-21 21:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-21 22:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t David Miller <davem@davemloft.net> - 2017-03-21 23:40 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t Kees Cook <keescook@chromium.org> - 2017-03-22 01:00 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-22 03:10 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-22 13:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-22 14:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-22 15:40 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-22 16:00 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-22 16:10 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-22 16:30 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-22 18:00 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t Kees Cook <keescook@chromium.org> - 2017-03-22 20:10 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-22 14:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-20 15:50 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-20 14:50 +0100
                RE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t David Laight <David.Laight@ACULAB.COM> - 2017-03-20 15:20 +0100
                Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t Peter Zijlstra <peterz@infradead.org> - 2017-03-20 15:30 +0100
                RE: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to  refcount_t David Laight <David.Laight@ACULAB.COM> - 2017-03-20 16:10 +0100
  [PATCH 05/17] net: convert sk_buff_fclones.fclone_ref from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 15/17] net: convert net.passive from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 16/17] net: convert netlbl_lsm_cache.refcount from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 09/17] net: convert ip_mc_list.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 04/17] net: convert sk_buff.users from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 08/17] net: convert sk_filter.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
    Re: [PATCH 08/17] net: convert sk_filter.refcnt from atomic_t to  refcount_t Daniel Borkmann <daniel@iogearbox.net> - 2017-03-16 17:10 +0100
      RE: [PATCH 08/17] net: convert sk_filter.refcnt from atomic_t to  refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-03-17 09:20 +0100
  [PATCH 17/17] net: convert packet_fanout.sk_ref from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 06/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100
  [PATCH 13/17] net: convert fib_rule.refcnt from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-03-16 16:40 +0100

csiph-web