Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg.

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg.
Date	2017-03-20 11:50 +0100
Message-ID	<tn32W-3u2-23@gated-at.bofh.it> (permalink)
References	<t7WG5-ld-3@gated-at.bofh.it> <t7WG6-ld-19@gated-at.bofh.it> <tm4u6-21N-33@gated-at.bofh.it> <tn054-1qT-23@gated-at.bofh.it> <tn26R-2MC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 20, 2017 at 05:43:29PM +0800, Fu Wei wrote:
> On 20 March 2017 at 15:36, Fu Wei <fu.wei@linaro.org> wrote:
> > On 18 March 2017 at 02:05, Mark Rutland <mark.rutland@arm.com> wrote:
> >> On Tue, Feb 07, 2017 at 02:50:03AM +0800, fu.wei@linaro.org wrote:

> >>> +static u32 arch_timer_get_mmio_freq(void __iomem *cntbase)
> >>> +{
> >>> +     /*
> >>> +      * Try to get the frequency from the CNTFRQ of timer frame registers.
> >>> +      * Note: please verify cntbase in caller.
> >>> +      */
> >>> +     return readl_relaxed(cntbase + CNTFRQ);
> >>> +}
> >>
> >> Wrapping the MMIO read makes sense if we're going to do this in more
> >> than one place, so I'm happy with this wrapper.
> >>
> >> If you can s/arch_timer_get_mmio_freq/arch_timer_get_cntfrq/, and drop
> >
> > sorry, May I guess that is
> > "s/arch_timer_get_mmio_freq/arch_timer_get_mmio_cntfrq/"
> > or
> > "s/arch_timer_get_mmio_freq/arch_timer_mem_get_cntfrq/"
> >
> > which one do you prefer? :-)
> 
> keeping using arch_timer_get_cntfrq();  for per-CPU arch timer, then
> 
> +static u32 arch_timer_mem_get_cntfrq(void __iomem *cntbase)
> +{
> +       return readl_relaxed(cntbase + CNTFRQ);
> +}
> +

That looks perfect to me.

Sorry for the confusion above!

Mark.

Thread

Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two  functions to get the frequency from mmio and sysreg. Mark Rutland <mark.rutland@arm.com> - 2017-03-17 19:10 +0100
  Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two  functions to get the frequency from mmio and sysreg. Fu Wei <fu.wei@linaro.org> - 2017-03-20 08:40 +0100
    Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two  functions to get the frequency from mmio and sysreg. Fu Wei <fu.wei@linaro.org> - 2017-03-20 10:50 +0100
      Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two  functions to get the frequency from mmio and sysreg. Mark Rutland <mark.rutland@arm.com> - 2017-03-20 11:50 +0100
        Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two  functions to get the frequency from mmio and sysreg. Fu Wei <fu.wei@linaro.org> - 2017-03-20 12:20 +0100

csiph-web