Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604255

RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

Show all headers | View raw

> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]
> Sent: 17 March, 2017 6:24 PM
> Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
> 
> 
> 
> > @@ -62,10 +66,33 @@
> >   */
> >  #define SDHCI_CDNS_MAX_TUNING_LOOP     40
> >
> > +static const struct of_device_id sdhci_cdns_match[];
> > +
> 
> You forgot to remove this.
> 
You are right. Thanks.
 
> 
> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> >         struct sdhci_cdns_priv *priv;
> >         struct clk *clk;
> >         int ret;
> > +       struct device *dev = &pdev->dev;
> >
> >         clk = devm_clk_get(&pdev->dev, NULL);
> 
> 
> If you add "dev", please use it for devm_clk_get, too.
> 
I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. 
Therefore I remove it. 

> 
> 
> --
> Best Regards
> Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[v3 1/3] mmc: sdhci-cadence: Fix writing PHY delay Piotr Sroka <piotrs@cadence.com> - 2017-03-17 13:40 +0100
  [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Piotr Sroka <piotrs@cadence.com> - 2017-03-17 14:20 +0100
    Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-17 18:30 +0100
      RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Piotr Sroka <piotrs@cadence.com> - 2017-03-20 10:00 +0100
        Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-21 03:00 +0100
          RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Piotr Sroka <piotrs@cadence.com> - 2017-03-21 09:10 +0100
    Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-17 18:40 +0100
  [v3 2/3] Documentation: bindings: add description of PHY delays for sdhci-cadence Piotr Sroka <piotrs@cadence.com> - 2017-03-17 14:20 +0100
    Re: [v3 2/3] Documentation: bindings: add description of PHY delays  for sdhci-cadence Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-17 18:40 +0100
      RE: [v3 2/3] Documentation: bindings: add description of PHY delays  for sdhci-cadence Piotr Sroka <piotrs@cadence.com> - 2017-03-20 10:10 +0100

csiph-web