Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP.

From	Anatolij Gustschin <agust@denx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP.
Date	2017-03-18 20:00 +0100
Message-ID	<tmrK2-27E-11@gated-at.bofh.it> (permalink)
References	<tjyI1-6Y-3@gated-at.bofh.it> <tjyI1-6Y-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Matthew,

On Fri, 10 Mar 2017 11:40:27 -0800
matthew.gerlach@linux.intel.com matthew.gerlach@linux.intel.com wrote:

...
>+#include "altera-pr-ip-core.h"

Shouldn't we put this header to include/linux? Compiling the
out-of-tree modules using alt_pr_register/alt_pr_unregister
will not work if this header is in drivers/fpga.

...
>+
>+module_platform_driver(alt_pr_platform_driver);

Please add MODULE_LICENSE("GPL v2") here. Otherwise, when built as
a module it cannot be loaded because the alt_pr register/unregister
functions are exported as GPL only. Also please add module author
and description.

Thanks,

Anatolij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial  Reconfiguration IP. Anatolij Gustschin <agust@denx.de> - 2017-03-18 20:00 +0100
  Re: [PATCH v5 4/4] fpga pr ip: Platform driver for Altera Partial  Reconfiguration IP. matthew.gerlach@linux.intel.com - 2017-03-21 00:50 +0100

csiph-web