Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604162

Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online

Show all headers | View raw

On 17-03-17, 18:40, Rafael J. Wysocki wrote:
> On Fri, Mar 17, 2017 at 5:43 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 17 March 2017 at 22:01, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> >> IMO if we are not going to restore the governor, we also should not
> >> restore the limits as those things are related.  Now, the governor can
> >> be unloaded while the CPU is offline.
> >
> > I thought about it earlier but then governor and policy min/max
> > looked independent to me. Why do you think they are related?
> 
> They are parts of one set of settings.
> 
> If the governor is not restored, the policy starts with the default
> one, so why would it not start with the default limits then?

Do we reset the limits when we change governor's normally? No. Then
why should we consider suspend/resume special in that sense? These are
completely different and independent settings which user has done and
we don't really need to relate them.

> My opinion is that either we restore everything the way it was, or we
> start afresh entirely.

What about fields like: policy->user_policy.*? They aren't reset for
existing policies if the last governor isn't found. And there are
drivers which call cpufreq_update_policy(), and that would mean that
the CPU will come back to user defined policies before system
suspended. And that kind of defeats whatever you were trying to do in
this patch. Isn't it?

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Restore policy min/max limits on CPU online "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-17 00:00 +0100
  Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-17 04:30 +0100
    Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online "Rafael J. Wysocki" <rafael@kernel.org> - 2017-03-17 17:40 +0100
      Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-17 18:00 +0100
        Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online "Rafael J. Wysocki" <rafael@kernel.org> - 2017-03-17 18:50 +0100
          Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-20 04:30 +0100
            Re: [PATCH] cpufreq: Restore policy min/max limits on CPU online "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-20 13:50 +0100
        [PATCH v2] cpufreq: Restore policy min/max limits on CPU online "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-17 19:00 +0100

csiph-web