Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603670

Re: [PATCH] drm: vc4: remove redundant check of plane being non-null

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer plane is always null on the error path at label 'fail'
> hence the check if it is non-null is redundant. We can therefore
> remove the check and the destruction of plane as well as the fail
> error path and instead just return an -ENOMEM ERR_PTR.
>
> Detected by CoverityScan, CID#1339532 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed and applied.  Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm: vc4: remove redundant check of plane being non-null Colin King <colin.king@canonical.com> - 2017-03-16 20:00 +0100
  Re: [PATCH] drm: vc4: remove redundant check of plane being non-null Eric Anholt <eric@anholt.net> - 2017-03-18 01:00 +0100

csiph-web