Re: [PATCH v3] tpm_crb: request and relinquish locality 0

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] tpm_crb: request and relinquish locality 0
Date	2017-03-17 21:40 +0100
Message-ID	<tm6Pf-3DI-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <tltuy-8nj-7@gated-at.bofh.it> <tlugV-Cf-7@gated-at.bofh.it> <tlCeu-6c9-5@gated-at.bofh.it> <tm3HI-1mJ-27@gated-at.bofh.it> <tm3HI-1mJ-25@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Mar 17, 2017 at 11:11:16AM -0600, Jason Gunthorpe wrote:
> On Fri, Mar 17, 2017 at 10:00:41AM -0700, Jerry Snitselaar wrote:
> 
> > > Changing the return value to -EBUSY was a stupid mistake from my side.
> > >
> > > I'll try revise this a bit in a way that the API will allow positive
> > > value for stating that the given locality has been already taking.
> > 
> > Is there a big performance hit with requesting and releasing locality?
> > If instead it just released it when release_locality is called I think
> > the changes are pretty minor.
> 
> If you can measure please let us know :)
> 
> This is all very old it may not actually make any sense..
> 
> .. and as I said earlier if we want to 'cache' the locality for
> performance then the core code should do it.
> 
> I kinda thought the point of releasing the locality was to allow other
> platform things to access the TPM, so I'm confused why TIS wouldn't
> always release it as well..
> 
> Jason

I would propose to make tpm_tis_core to work like that.

/Jarkko

Thread

[PATCH v3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@iki.fi> - 2017-03-15 07:00 +0100
  Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-16 03:40 +0100
    Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-16 04:30 +0100
      Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-16 13:00 +0100
        Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-17 18:20 +0100
          Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-17 21:40 +0100
        Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-17 18:30 +0100
          Re: [PATCH v3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-17 21:40 +0100

csiph-web