Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603570

Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping failure

Show all headers | View raw

Hi Andy,


On 03/17/2017 11:38 AM, Andy Shevchenko wrote:
> On Fri, Mar 17, 2017 at 7:37 PM, sathyanarayanan kuppuswamy
> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
>> On 03/17/2017 07:25 AM, Andy Shevchenko wrote:
>>> On Fri, Mar 17, 2017 at 3:40 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>> On 03/17/2017 04:43 AM, Rajneesh Bhardwaj wrote:
>>>>> On Thu, Mar 16, 2017 at 05:41:35PM -0700, Kuppuswamy Sathyanarayanan
>>>>> wrote:
>>> I already asked once [1] to fix up the mess we have in PDx86 regarding SCU
>>> IPC.
>>> (PMC IPC how it's called is actually just a [main] part of SCU in newer
>>> SoCs).
>>>
>>> Rajneesh, Kuppuswamy,
>>> please pay attention on the below.
>>>
>>> We have two libraries doing almost the same (basics) one for old
>>> platforms, one for new.
>>>
>>> My vision what should be done before we go further is:
>>> 1. Split out common part from intel_scu_ipc and intel_pmc_ipc to some
>>> library.
>> I think we should create MFD driver for PMC and remove the redundant
>> resource and platform device creation codes.
>> Yes, there is common code in IPC implementation between scu_ipc and pmc_ipc
>> code. This needs be modularized.
>>
>> I can work on it and send a RFC patch for this cleanup. But it could take
>> more time for merging this cleanup patch.
>> So I think, in the mean time, we should merge this watchdog fix first to
>> remove iTCO watchdog device probe issue.
> I have heard already such excuses. Let's consider this as a "Last
> Chinese Warning".
>
> So, we consider reviewing applying *already floating around* patches
> in exchange to looking forward for clean up next.
> Do we have a deal?
Deal.
>
> Before you are going to implement anything in the code, please, share
> a document (architectural point of view) how you would see things
> should be done.
> Also consider to address PMC (Atom drivers) and P-Unit drivers which
> are related to SCU / IPC to have some structure.
Will send out the design document summarizing the issues we want to 
solve and a proposed design model.
>
>>> 2. Move headers to linux/platform_data/x86 for sharing with drivers
>>> that are supporting non-Intel / not-newest-Intel hardware.
>>> 3. Fix the mess inside the intel_pmc_ipc code (like use devm_()
>>> helpers where it makes sense, no use of global variables, etc)
>> Agreed.
>>>
>>> On top of that
>>> 4. Fix up Whiskey Cove PMIC code (See Hans' message [2] for the details)
>>>
>>> [1] Oops, it happened on internal mailing list Jan 27. And mentioned
>>> publicly after in a review on some patch here.
>>> [2] http://lkml.iu.edu/hypermail/linux/kernel/1702.3/01408.html

-- 
Sathyanarayanan Kuppuswamy
Android kernel developer

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size Kuppuswamy Sathyanarayanan          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-16 04:40 +0100
  Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-16 16:00 +0100
    Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-16 17:10 +0100
      Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-16 19:20 +0100
        Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-16 21:20 +0100
          Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-16 22:20 +0100
    Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-16 20:00 +0100
      Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-16 20:30 +0100
        Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping  size sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-16 22:30 +0100
        [PATCH v2 2/4] platform/x86: intel_pmc_ipc: Add pmc gcr read/write api's Kuppuswamy Sathyanarayanan          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 01:50 +0100
          Re: [PATCH v2 2/4] platform/x86: intel_pmc_ipc: Add pmc gcr  read/write api's Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-17 12:30 +0100
            Re: [PATCH v2 2/4] platform/x86: intel_pmc_ipc: Add pmc gcr  read/write api's sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 18:40 +0100
        [PATCH v2 4/4] platform/x86: intel_pmc_ipc: remove iTCO GCR mem resource Kuppuswamy Sathyanarayanan          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 01:50 +0100
          Re: [PATCH v2 4/4] platform/x86: intel_pmc_ipc: remove iTCO GCR mem  resource Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-17 12:50 +0100
        [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping failure Kuppuswamy Sathyanarayanan          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 01:50 +0100
          Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-17 12:50 +0100
            Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure Guenter Roeck <linux@roeck-us.net> - 2017-03-17 14:50 +0100
              Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-17 15:10 +0100
              Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping failure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-17 15:30 +0100
                Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 18:50 +0100
                Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping failure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-17 19:40 +0100
                Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 20:00 +0100
              Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure Guenter Roeck <linux@roeck-us.net> - 2017-03-17 19:00 +0100
                Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 19:50 +0100
              Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 21:50 +0100
            Re: [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping  failure sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 18:30 +0100
        [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset Kuppuswamy Sathyanarayanan          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 02:00 +0100
          Re: [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-03-17 12:20 +0100
            Re: [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-03-17 18:20 +0100

csiph-web