Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603501

[tip:timers/core] tick/broadcast: Make tick_broadcast_setup_oneshot() static

Show all headers | View raw

Commit-ID:  f5e38e7c86427bd7c01b259a9655cb6a9aba5cb7
Gitweb:     http://git.kernel.org/tip/f5e38e7c86427bd7c01b259a9655cb6a9aba5cb7
Author:     Stephen Boyd <sboyd@codeaurora.org>
AuthorDate: Thu, 16 Mar 2017 18:08:14 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 17 Mar 2017 18:24:59 +0100

tick/broadcast: Make tick_broadcast_setup_oneshot() static

This function isn't used outside of tick-broadcast.c, so make it static.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Link: http://lkml.kernel.org/r/20170317010814.2591-2-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/time/tick-broadcast.c | 4 +++-
 kernel/time/tick-internal.h  | 2 --
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 987e496..1f534dd 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -152,6 +152,8 @@ static void tick_device_setup_broadcast_func(struct clock_event_device *dev)
 	}
 }
 
+static void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
+
 /*
  * Check, if the device is disfunctional and a place holder, which
  * needs to be handled by the broadcast device.
@@ -867,7 +869,7 @@ static void tick_broadcast_init_next_event(struct cpumask *mask,
 /**
  * tick_broadcast_setup_oneshot - setup the broadcast device
  */
-void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
+static void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
 {
 	int cpu = smp_processor_id();
 
diff --git a/kernel/time/tick-internal.h b/kernel/time/tick-internal.h
index f738251..be0ac01 100644
--- a/kernel/time/tick-internal.h
+++ b/kernel/time/tick-internal.h
@@ -126,7 +126,6 @@ static inline int tick_check_oneshot_change(int allow_nohz) { return 0; }
 
 /* Functions related to oneshot broadcasting */
 #if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_TICK_ONESHOT)
-extern void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
 extern void tick_broadcast_switch_to_oneshot(void);
 extern void tick_shutdown_broadcast_oneshot(unsigned int cpu);
 extern int tick_broadcast_oneshot_active(void);
@@ -134,7 +133,6 @@ extern void tick_check_oneshot_broadcast_this_cpu(void);
 bool tick_broadcast_oneshot_available(void);
 extern struct cpumask *tick_get_broadcast_oneshot_mask(void);
 #else /* !(BROADCAST && ONESHOT): */
-static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); }
 static inline void tick_broadcast_switch_to_oneshot(void) { }
 static inline void tick_shutdown_broadcast_oneshot(unsigned int cpu) { }
 static inline int tick_broadcast_oneshot_active(void) { return 0; }

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] hrtimer: hrtimer_peek_ahead_timers() is gone Stephen Boyd <sboyd@codeaurora.org> - 2017-03-17 02:10 +0100
  [PATCH 2/2] tick/broadcast: tick_broadcast_setup_oneshot() isn't exported Stephen Boyd <sboyd@codeaurora.org> - 2017-03-17 02:10 +0100
    Re: [tip:timers/core] tick/broadcast: Make tick_broadcast_setup_oneshot()  static Thomas Gleixner <tglx@linutronix.de> - 2017-03-17 18:50 +0100
      Re: [tip:timers/core] tick/broadcast: Make  tick_broadcast_setup_oneshot() static Stephen Boyd <sboyd@codeaurora.org> - 2017-03-17 19:30 +0100
    [tip:timers/core] tick/broadcast: Make  tick_broadcast_setup_oneshot() static tip-bot for Stephen Boyd <tipbot@zytor.com> - 2017-03-17 18:50 +0100
  [tip:timers/core] hrtimer: Remove hrtimer_peek_ahead_timers()  leftovers tip-bot for Stephen Boyd <tipbot@zytor.com> - 2017-03-17 18:50 +0100

csiph-web