Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1603539
| From | Akshay Bhat <akshay.bhat@timesys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver |
| Date | 2017-03-17 19:40 +0100 |
| Message-ID | <tm4X7-2fG-13@gated-at.bofh.it> (permalink) |
| References | (10 earlier) <tlJSG-3pV-27@gated-at.bofh.it> <tlMdQ-4Yc-5@gated-at.bofh.it> <tlUEq-2QJ-3@gated-at.bofh.it> <tm2BX-FF-9@gated-at.bofh.it> <tm414-1ya-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Wolfgang,
On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote:
>
> Hm, that's unusual. Cable disconnected and then send a message:
>
> $ grep /proc/interrupts; sleep 10; /proc/interrupts
>
> should make things clear. But maybe it's a clever chip and it does stop
> sending error messages if the error counter does not change any more.
> After bus-off, the chip is quiet, of course. Should have a closer look
> to the CAN standard.
>
The interrupt count does not increment after device reaches
tx-error-passive (with cable disconnected).
# while true; do grep -i hi3110 /proc/interrupts; sleep 10; done &
[1] 793
#
111: 0 0 gpio-mxc 12 Edge hi3110
# candump -t d -e any,0:0,#FFFFFFF &
[2] 798
# cansend can0 123#
#
(000.000000) can0 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
controller-problem{tx-error-warning}
error-counter-tx-rx{{96}{0}}
(000.002122) can0 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME
controller-problem{tx-error-passive}
error-counter-tx-rx{{128}{0}}
111: 10 0 gpio-mxc 12 Edge hi3110
111: 10 0 gpio-mxc 12 Edge hi3110
111: 10 0 gpio-mxc 12 Edge hi3110
>>> So far using NAPI was mandatory. There is the problem of out-of-order
>>> message reception if handled in the isr on multi processor systems.
>>> Marc, what is the current policy?
>>>
>>
>> Since this is a SPI based CAN, I am wary for any additional latencies
>> NAPI might introduce. The RX handling is being done at the very
>> beginning of the ISR for this reason.
>>
>> Can we go ahead with the existing implementation and re-visit this at a
>> later time?
>
> Likely yes, as Marc has already reviewed the driver once.
>
Thanks, I will go ahead and submit v4 patch.
> BTW: what system board/processor are you using?
>
It is a custom board using Phytec phyFLEX-i.MX6 Dual SOM.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-14 13:20 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <akshay.bhat@timesys.com> - 2017-03-14 17:30 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-14 19:10 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-14 22:30 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <nodeax@gmail.com> - 2017-03-15 05:50 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-15 08:30 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-15 10:50 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <akshay.bhat@timesys.com> - 2017-03-16 18:10 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-16 21:10 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <akshay.bhat@timesys.com> - 2017-03-16 23:40 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-17 08:40 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-17 09:20 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <akshay.bhat@timesys.com> - 2017-03-17 17:10 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-17 18:40 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat <akshay.bhat@timesys.com> - 2017-03-17 19:40 +0100
Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Wolfgang Grandegger <wg@grandegger.com> - 2017-03-18 13:40 +0100
csiph-web