Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

From	Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral
Date	2017-03-17 15:10 +0100
Message-ID	<tm0JQ-7zo-23@gated-at.bofh.it> (permalink)
References	<tlfBg-73v-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 15, 2017 at 12:43:56PM +0100, Jonathan Neuschäfer wrote:
[...]
> - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths:
>   smsm, smsm->entries, etc. are allocated (with devm_kzalloc), but not
>   freed when the function returns early. This should be addressed at
>   some point (in a separate patch).

This is not actually true (see Documentation/driver-model/devres.txt).
Sorry for the noise.


Jonathan Neuschäfer

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] soc: qcom: smsm: Handle probe deferral Jonathan Neuschäfer <j.neuschaefer@gmx.net> - 2017-03-15 12:50 +0100
  [PATCH 2/2] soc: qcom: smsm: Avoid the use of an uninitialized value Jonathan Neuschäfer <j.neuschaefer@gmx.net> - 2017-03-15 12:50 +0100
  Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral Jonathan Neuschäfer <j.neuschaefer@gmx.net> - 2017-03-17 15:10 +0100

csiph-web