Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1602098

Re: ath10k: remove redundant error check

From Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups linux.kernel
Subject Re: ath10k: remove redundant error check
Date 2017-03-16 10:00 +0100
Message-ID <tlzqi-4aX-17@gated-at.bofh.it> (permalink)
References <tfOBI-3VC-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The check on ret for an error is redundant because it is already been
> checked for non-zero earlier on and ret is never non-zero at this point.
> Fix this by removing the redundant check and error message.
> 
> Detected by CoverityScan, CID#1357170 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to ath-next branch of ath.git, thanks.

51f60b8b6979 ath10k: remove redundant error check

-- 
https://patchwork.kernel.org/patch/9595221/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: ath10k: remove redundant error check Kalle Valo <kvalo@qca.qualcomm.com> - 2017-03-16 10:00 +0100

csiph-web