Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602005

Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c

Show all headers | View raw

On Thu, Mar 16, 2017 at 06:51:54AM +0000, Okash Khawaja wrote:
> On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> > On Tue, Mar 14, 2017 at 01:41:55PM +0000, Okash Khawaja wrote:
> > > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > > serialio.c. These functions do outgoing serial comms. The move is a step
> > > towards collecting all serial comms in serialio.c. This also renames
> > > spk_synth_immediate to spk_serial_synth_immediate.
> > > 
> > > Code inside those functions has not been changed. Along the way, this patch
> > > also fixes a couple of spots which were calling spk_synth_immediate directly,
> > > so that the calls now happen via the spk_syth struct.
> > > 
> > > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> > > Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > > 
> > > Index: linux-4.11-rc2/drivers/staging/speakup/serialio.c
> > 
> > This patch doesn't apply to my tree at all.  The first 3 applied with
> > some fuzz, so I think you are not working against linux-next. Please
> > rebase your patch against linux-next, or my staging-testing branch, and
> > resend so I can apply it.
> 
> Sure, will rebase against staging-testing. Just this patch or the
> patch set?

I applied the first 3, so if you rebase, they should just "go away" :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 0/4] staging: speakup: refactor to make raw serial i/o swappable Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-14 14:50 +0100
  [patch 1/4] staging: speakup: spk_serial_out and spk_wait_for_xmitr to take synth arg Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-14 14:50 +0100
  [patch 2/4] staging: serial: add spk_io_ops struct to spk_synth Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-14 15:00 +0100
  [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-14 15:00 +0100
    Re: [patch 4/4] staging: speakup: move those functions which do  outgoing serial comms, into serialio.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-16 03:20 +0100
      Re: [patch 4/4] staging: speakup: move those functions which do  outgoing serial comms, into serialio.c Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-16 08:00 +0100
        Re: [patch 4/4] staging: speakup: move those functions which do  outgoing serial comms, into serialio.c Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-16 08:10 +0100
          [patch 4/4] staging: speakup: move those functions which do outgoing  serial comms, into serialio.c Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-16 09:20 +0100

csiph-web