Groups > linux.kernel > #1601924

[PATCH] Staging: goldfish: use func instead of embedded function names

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Mohsin Shan <mohsinshan1k@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Staging: goldfish: use __func__ instead of embedded function names
Date	Thu, 16 Mar 2017 05:00:01 +0100
Message-ID	<tluJX-OO-1@gated-at.bofh.it> (permalink)
X-Original-To	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, mohsinshan1k@gmail.com, educha997@gmail.com
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=Vfgbig2X1iOiFOWgmb1vvYXPpSgUpTsza571g2KHm8g=; b=nfMeLEqv3t35qXq6DTGe6sazKg3IESYqKKApEEYJl8m67pmJve6wkqJHw4hKYBfy8v RUtOw5FM3h6tVpriYEVj1YkUGAMOIVBGYzQxfjBY70ScR8cv29N/AlMfgxvc0BO8u1UH 97sYZf7y29luKIYVelYfLhYHKtl9HGofDiEhYU3X1/7cyfhYcWjR1l1ieZxv9MzpMSEL z3Yt6ghC9t9u2mcH4fjaGfp7m9tPJTz+eI7blCvnbbcIhLjdpW9iyndpFswLND8ej1iP Vr7XjF6ZxMKrrWC7lDnRQjMfdv8U9LGQHRClCsh8JwqEzjGGBhWOW39NMEk9wB8l+P6x PtvA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Vfgbig2X1iOiFOWgmb1vvYXPpSgUpTsza571g2KHm8g=; b=f0lbjcp76UHdm3otY8r4kf6kl0k2AoJjyec0398s16pNHLdSMd4vsbuypE04v+l6cS C0TyESdWL+sNIpIaYANSZ5jljRroqk8xF3SBcUUh8xhQ0jTaIUGk2Xx3lH7JD7HoHwFc b1YmsN7hGdAMxE3/Pj4xYGExHMVjf5zFBJVqcTPB6OcUXKnuYdoQ/pOuv2GLPIEkQptK Vb3Xla1Epayg1OazOhxTD5b0FI5sr+P4tzfvK0HBL9R6bw61afQhNhGHIYylLe0Zhtfs MEAAMcRlOPgf8aJte5LAhAji78AFAQrc6IdkXh7TArbsO4WtC8rfLtq6iaRBh5qYkelb 2G+g==
X-Gm-Message-State	AFeK/H2faj4vt+hzY65N+ZiO90A9sXcIdAcsDO2Vg28ebRmM/+Sx5m4TmOZPqBXVkhbUuQ==
X-Received	by 10.223.135.85 with SMTP id 21mr5811471wrz.93.1489636309301; Wed, 15 Mar 2017 20:51:49 -0700 (PDT)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Date	Wed, 15 Mar 2017 20:51:42 -0700
X-Original-Message-ID	<1489636302-12321-1-git-send-email-mohsinshan1k@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601924

Show key headers only | View raw

Embedded function names are less appropriate to use when
refactoring, can cause function renaming.  Prefer the use
of "%s", __func__ to embedded function names

Signed-off-by: Mohsin Shan <mohsinshan1k@gmail.com>
---
 drivers/staging/goldfish/goldfish_nand.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c
index 76d60ee..8f92ff4 100644
--- a/drivers/staging/goldfish/goldfish_nand.c
+++ b/drivers/staging/goldfish/goldfish_nand.c
@@ -114,8 +114,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr)
 	len = len / mtd->writesize * (mtd->writesize + mtd->oobsize);
 
 	if (goldfish_nand_cmd(mtd, NAND_CMD_ERASE, ofs, len, NULL) != len) {
-		pr_err("goldfish_nand_erase: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n",
-		       ofs, len, mtd->size, mtd->erasesize);
+		pr_err("%s: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n",
+		       __func__, ofs, len, mtd->size, mtd->erasesize);
 		return -EIO;
 	}
 
@@ -125,8 +125,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr)
 	return 0;
 
 invalid_arg:
-	pr_err("goldfish_nand_erase: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n",
-	       ofs, len, mtd->size, mtd->erasesize);
+	pr_err("%s: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n",
+	       __func__, ofs, len, mtd->size, mtd->erasesize);
 	return -EINVAL;
 }
 
@@ -254,8 +254,8 @@ static int goldfish_nand_block_isbad(struct mtd_info *mtd, loff_t ofs)
 	return goldfish_nand_cmd(mtd, NAND_CMD_BLOCK_BAD_GET, ofs, 0, NULL);
 
 invalid_arg:
-	pr_err("goldfish_nand_block_isbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n",
-	       ofs, mtd->size, mtd->writesize);
+	pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n",
+	       __func__, ofs, mtd->size, mtd->writesize);
 	return -EINVAL;
 }
 
@@ -277,8 +277,8 @@ static int goldfish_nand_block_markbad(struct mtd_info *mtd, loff_t ofs)
 	return 0;
 
 invalid_arg:
-	pr_err("goldfish_nand_block_markbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n",
-	       ofs, mtd->size, mtd->writesize);
+	pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n",
+	       __func__, ofs, mtd->size, mtd->writesize);
 	return -EINVAL;
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: goldfish: use __func__ instead of embedded function names Mohsin Shan <mohsinshan1k@gmail.com> - 2017-03-16 05:00 +0100
  Re: [PATCH] Staging: goldfish: use __func__ instead of embedded  function names Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-16 12:20 +0100

csiph-web