Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks

From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks
Date	2017-03-16 03:30 +0100
Message-ID	<tltkS-8jX-13@gated-at.bofh.it> (permalink)
References	<tecf8-CA-5@gated-at.bofh.it> <tltkR-8jX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > +	memset(&al, 0, sizeof(al));
> > +	if (end - start > MAXBB - MAXINSN) {
> > +		if (last)
> > +			printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> > +					start, end);
> > +		else
> > +			printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",

Thanks. Should be %" PRIu64 " of course.

Arnaldo, can you do the change or should I send a patch?

-Andi

> > +					start, end, end - start);
> 
> This looks to be breaking the build on ppc64:
> 
>   builtin-script.c: In function ‘grab_bb’:
>   builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
>       printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start);
>              ^
> 
> cheers
>

Thread

Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 03:30 +0100
  Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks Andi Kleen <andi@firstfloor.org> - 2017-03-16 03:30 +0100
    Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-16 13:30 +0100

csiph-web