Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1601832
| Path | csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alex Deucher <alexdeucher@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] drm/amdgpu: remove unneeded conversions to bool |
| Date | Thu, 16 Mar 2017 02:30:01 +0100 |
| Message-ID | <tlsoN-7DD-3@gated-at.bofh.it> (permalink) |
| References | <tljYd-1Jv-21@gated-at.bofh.it> |
| X-Original-To | "Andrew F. Davis" <afd@ti.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JsreF0z383tLCPz5Wntl3x9WWugmVzgrSotQ30zwN6Y=; b=eV7eg7Hd7fTLgfBRx09EtlELaJo+E3B5ScrbcyxgQQ7HZ2LaMfsnpG/B/vcVwOpctY eLr567MJQOBjFje0xrgmTAiNnrc850IDxy2THFVJNxnEBwDniZszh6r6mzNQ/N13OmTv OWuxDY690Cop3+AtWAaaQQdaOg+NcIPorELbYUwMpfnDuEy9ZpkDsGIK7lv5nWYg1fr0 uiHuLFejSqM44bc9/TfDa2ljr/dX2LZdSK8+iTGLbqhPQo+Ys/SZsJ05s4JMxq/EOpz0 oqIgpepAsJc0PAtvCGVvVs1Uax2shz4Z/EkZTZhf1f4jOo66ubbhSQmzKliyE6C7pc7g 8CCw== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JsreF0z383tLCPz5Wntl3x9WWugmVzgrSotQ30zwN6Y=; b=G0pJvzw8fpB2Lo0mpagbHt0hcCsoMtC9RFbaEMvkYXJ29vw5HiRnB+0yNA7kyRX/eh Lq3D10+9mJphBBnUEOnRP98hntq6ljsywmMXmqzY9A0JxP9GIgJ/gcTLurF2JqfIMuwu BZ8QehEWJivC76G0AXJXR+2KJn5D108WxsnZDyYvFY0J99NP7ZIAQr8pJgrd6JUpjKiB NNACMunj32qUJznzpZ30MddXc6C0S+jlt60UBZAsv7pYRShoU2GZz8X5DN49qstRdHKV gXE0kjBiv/Qiqypt6WhaRN2UBEzDU05reNnnCU0w9qr3knXPYn3POxEWPjcD8Q5d2wRK CkdQ== |
| X-Gm-Message-State | AFeK/H0yZCzXQIN9e2ZI+H8BmxFVL/w+Tgg5oxP+YdfbrPu85+iQWFPHP06eqD2lgnpPRpyg9I3p3j2ATAD6Wg== |
| X-Received | by 10.129.70.8 with SMTP id t8mr4867371ywa.61.1489627667430; Wed, 15 Mar 2017 18:27:47 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Content-Transfer-Encoding | quoted-printable |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 144 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Alex Deucher <alexander.deucher@amd.com>, Christian König <christian.koenig@amd.com>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, Maling list - DRI developers <dri-devel@lists.freedesktop.org> |
| X-Original-Date | Wed, 15 Mar 2017 21:27:47 -0400 |
| X-Original-Message-ID | <CADnq5_P6fjvN7Urv3aKsA27+D+a++rK6ODSr_0qZmiUDBvy7Xw@mail.gmail.com> |
| X-Original-References | <20170315162024.11906-1-afd@ti.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1601832 |
Show key headers only | View raw
On Wed, Mar 15, 2017 at 12:20 PM, Andrew F. Davis <afd@ti.com> wrote:
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
>
> Changes from v1:
> - Rebased on v4.11-rc1
> - Added Reviewed-by
Applied the series. thanks,
Alex
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/vi.c | 16 ++++++++--------
> 4 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 67afc901905c..52f39d8627de 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -5839,7 +5839,7 @@ static int gfx_v8_0_set_powergating_state(void *handle,
> enum amd_powergating_state state)
> {
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> - bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
> + bool enable = (state == AMD_PG_STATE_GATE);
>
> switch (adev->asic_type) {
> case CHIP_CARRIZO:
> @@ -6416,7 +6416,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> gfx_v8_0_update_gfx_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> case CHIP_TONGA:
> gfx_v8_0_tonga_update_gfx_clock_gating(adev, state);
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> index 7669b3259f35..e570decc2d23 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> @@ -1430,9 +1430,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
> switch (adev->asic_type) {
> case CHIP_FIJI:
> fiji_update_mc_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> fiji_update_mc_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 31375bdde6f1..db02bc6a2fa2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -1517,9 +1517,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> index 50bdb24ef8d6..8e71b74d5a15 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> @@ -1394,24 +1394,24 @@ static int vi_common_set_clockgating_state(void *handle,
> switch (adev->asic_type) {
> case CHIP_FIJI:
> vi_update_bif_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_rom_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> vi_update_bif_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_drm_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> case CHIP_TONGA:
> case CHIP_POLARIS10:
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 1/2] drm/amdgpu: remove unneeded conversions to bool "Andrew F. Davis" <afd@ti.com> - 2017-03-15 17:30 +0100 Re: [PATCH v2 1/2] drm/amdgpu: remove unneeded conversions to bool Alex Deucher <alexdeucher@gmail.com> - 2017-03-16 02:30 +0100
csiph-web