Re: [scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR

From	Subhash Jadavani <subhashj@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR
Date	2017-03-16 00:10 +0100
Message-ID	<tlqdk-6eS-11@gated-at.bofh.it> (permalink)
References	<tkTKp-8tD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-03-14 05:19, Tomas Winkler wrote:
> IS_ERR and ERR_PTR already forcefully cast their argument,
> hence there is no need for additional (complex) casting.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/scsi/ufs/ufshcd-pltfrm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c 
> b/drivers/scsi/ufs/ufshcd-pltfrm.c
> index a72a4ba78125..8e5e6c04c035 100644
> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
> @@ -309,8 +309,8 @@ int ufshcd_pltfrm_init(struct platform_device 
> *pdev,
> 
>  	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	mmio_base = devm_ioremap_resource(dev, mem_res);
> -	if (IS_ERR(*(void **)&mmio_base)) {
> -		err = PTR_ERR(*(void **)&mmio_base);
> +	if (IS_ERR(mmio_base)) {
> +		err = PTR_ERR(mmio_base);
>  		goto out;
>  	}

LGTM.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR Tomas Winkler <tomas.winkler@intel.com> - 2017-03-14 13:30 +0100
  Re: [scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-16 00:10 +0100
  Re: [scsi] scsi: ufshcd-platform: remove the useless cast in  ERR_PTR/IS_ERR Subhash Jadavani <subhashj@codeaurora.org> - 2017-03-16 00:10 +0100

csiph-web