Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601777

Re: [PATCH] netxen_nic: remove redundant check if retries is zero

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] netxen_nic: remove redundant check if retries is zero
Date 2017-03-15 23:10 +0100
Message-ID <tlphg-5w5-19@gated-at.bofh.it> (permalink)
References <tljbP-16B-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin King <colin.king@canonical.com>
Date: Wed, 15 Mar 2017 15:31:58 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> At the end of the timeout loop, retries will always be zero so
> the check for zero is redundant so remove it.  Also replace
> printk with pr_err as recommended by checkpatch.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] netxen_nic: remove redundant check if retries is zero Colin King <colin.king@canonical.com> - 2017-03-15 16:40 +0100
  Re: [PATCH] netxen_nic: remove redundant check if retries is zero David Miller <davem@davemloft.net> - 2017-03-15 23:10 +0100

csiph-web