Re: [PATCH] tpm: select CONFIG_CRYPTO

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: select CONFIG_CRYPTO
Date	2017-03-15 19:00 +0100
Message-ID	<tllnk-2AP-27@gated-at.bofh.it> (permalink)
References	<tl2ul-6hH-17@gated-at.bofh.it> <tlcDo-530-1@gated-at.bofh.it> <tlfBg-73v-25@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Mar 15, 2017 at 12:39:16PM +0100, Arnd Bergmann wrote:
> On Wed, Mar 15, 2017 at 9:30 AM, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> > Arnd,
> >
> > On Tue, Mar 14, 2017 at 10:40:24PM +0100, Arnd Bergmann wrote:
> >> As we need the CRYPTO_HASH_INFO implementation, we should also
> >> select CRYPTO itself to avoid this build warning:
> >>
> >> warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
> >>
> >> Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I've already merged this and put to my next branch.
> 
> Ah, I see my mistake: I had made an identical patch earlier, which you merged
> into linux-next, and I dropped it from my series after rebasing on
> -next, but then
> rebased again on mainline and did the new patch without checking whether
> it was already fixed in -next.
> 
> I guess the warning is rare enough that we don't really need this in v4.11
> even though it does apply there.
> 
>     Arnd

Ah. Right, now that I remember that was my conclusion. I'm sorry that
I did not remember to respond :-) If you think this would make sense
for 4.11 I could send it to stable.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: select CONFIG_CRYPTO Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:50 +0100
  Re: [PATCH] tpm: select CONFIG_CRYPTO Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-15 09:40 +0100
    Re: [PATCH] tpm: select CONFIG_CRYPTO Arnd Bergmann <arnd@arndb.de> - 2017-03-15 12:50 +0100
      Re: [PATCH] tpm: select CONFIG_CRYPTO Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-15 19:00 +0100

csiph-web