Re: [RFC PATCH 0/4] pinctrl: rockchip: PREEMPT_RT_FULL fixes

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 0/4] pinctrl: rockchip: PREEMPT_RT_FULL fixes
Date	Wed, 15 Mar 2017 18:20:02 +0100
Message-ID	<tlkKC-2iu-7@gated-at.bofh.it> (permalink)
References	<tkD2V-4vZ-3@gated-at.bofh.it>
User-Agent	KMail/5.2.3 (Linux/4.9.0-1-amd64; KDE/5.27.0; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	8BIT
Content-Type	text/plain; charset="iso-8859-1"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 15 Mar 2017 18:09:52 +0100
X-Original-Message-ID	<2965030.XxB81LuoOf@phil>
X-Original-References	<20170313183813.3582-1-john@metanate.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601578

Show key headers only | View raw

Am Montag, 13. März 2017, 18:38:09 CET schrieb John Keeping:
> As described in Documentation/gpio/driver.txt, we should not be using
> sleepable APIs in the irqchip implementation.  Since this includes the
> regmap API, this patch series ends up moving the mux setup for IRQs into
> an irq_bus_sync_unlock() handler which may result in the IRQ being
> configured before the port has been muxed as a GPIO.
> 
> I've marked the series as RFC because I'm not sure if this is the best
> way to accomplish this or if there is another approach that is cleaner.
> Also, the first patch may not be correct on RK3399 because I originally
> wrote the patch for RK3288 on top of v4.4 where all drive updates only
> affect a single register.  We don't need locking in this case because
> regmap_update_bits() takes a lock on the regmap internally, but if these
> two registers need to be updated atomically then another lock will
> be required here - slock cannot be used if it is converted to a raw
> spinlock since with full RT preemption the regmap's spinlock may sleep.

With the issue in patch2 fixed and top of the current head of Linus T's tree 
(4.11-rc2 + some patches), at least rk3036, rk3288, rk3368 and rk3399 come up 
nicely including multiple (1 to 3 per board) gpio-interrupts, so this series

Tested-by: Heiko Stuebner <heiko@sntech.de>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH 0/4] pinctrl: rockchip: PREEMPT_RT_FULL fixes Heiko Stuebner <heiko@sntech.de> - 2017-03-15 18:20 +0100

csiph-web