Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses
Date	2017-03-15 17:00 +0100
Message-ID	<tljvc-1eE-3@gated-at.bofh.it> (permalink)
References	<tlhtn-8mr-5@gated-at.bofh.it> <tljlw-1aZ-21@gated-at.bofh.it> <tljvc-1eE-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 15 Mar 2017 16:49:54 +0100
Jiri Slaby <jslaby@suse.cz> wrote:

> On 03/15/2017, 04:40 PM, Steven Rostedt wrote:
> >> -#else
> >> -# define function_hook	mcount
> >> -EXPORT_SYMBOL(mcount)
> >> -#endif
> >> -
> >>  /* All cases save the original rbp (8 bytes) */
> >>  #ifdef CONFIG_FRAME_POINTER
> >>  # ifdef CC_USING_FENTRY
> >> @@ -297,6 +290,7 @@ trace:
> >>  	jmp fgraph_trace
> >>  END(function_hook)
> >>  #endif /* CONFIG_DYNAMIC_FTRACE */
> >> +EXPORT_SYMBOL(function_hook)  
> > 
> > Under certain configs, this will fail the build. EXPORT_SYMBOL() does
> > not take the function_hook as a macro nicely. See commit 5de0a8c0c24033.  
> 
> Ok, thanks, forget about it then. I had the patch in my tree since Feb 3
> 2014, so I can finally drop it...
> 
> 

Great, cause I'm currently cleaning up that code too, and this would
cause conflicts ;-)

-- Steve

Thread

[PATCH 1/1] fentry: x86, cleanup function_hook uses Jiri Slaby <jslaby@suse.cz> - 2017-03-15 14:50 +0100
  Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses Steven Rostedt <rostedt@goodmis.org> - 2017-03-15 16:50 +0100
    Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses Steven Rostedt <rostedt@goodmis.org> - 2017-03-15 17:00 +0100
      Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses Jiri Slaby <jslaby@suse.cz> - 2017-03-15 17:20 +0100
    Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses Jiri Slaby <jslaby@suse.cz> - 2017-03-15 17:00 +0100

csiph-web