Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601469

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Mar 11, 2017 at 11:59:22PM +0000, Tom Rini wrote:

> On some architectures, such as arm64, KBUILD_IMAGE is not a full path
> but instead just the build target.  The builddeb script handles this
> case correctly today and will try arch/$ARCH/boot/$KBUILD_IMAGE so we
> can just borrow that logic and adapt it slightly for spec file syntax.
> 
> Cc: Michal Marek <mmarek@suse.com>
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> It is currently a mixed-bag on if architectures will use a build target
> (arm, arm64, arc are certainly by inspection and a few others 'may') or
> a full path (x86, blackfin, s390).  Given that builddeb gets this case
> correct, I think changing mkspec is the right way to go here.

I found https://patchwork.kernel.org/patch/9442211/ today and I see that
it was brought up again just before I sent my patch.  I just want to
point out that 9442211 doesn't address arm, arc, and sh and they will
still not have a functional rpm build target.  This is at least probably
important for arm.  Of course all of those could also be addressed with
a patch similar to 9442211, and my main concern is making sure
everything gets fixed one way or another.  Thanks!

-- 
Tom

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full  path Tom Rini <trini@konsulko.com> - 2017-03-15 16:00 +0100
  Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full  path Michal Marek <mmarek@suse.com> - 2017-03-15 16:10 +0100
    Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full  path Tom Rini <trini@konsulko.com> - 2017-03-15 16:40 +0100
      Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full  path Will Deacon <will.deacon@arm.com> - 2017-03-20 11:20 +0100
        Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-20 18:10 +0100

csiph-web