Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601434

Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts
Date 2017-03-15 15:20 +0100
Message-ID <tlhWp-lx-9@gated-at.bofh.it> (permalink)
References <tlhD4-8pQ-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote:
> Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
> phy_suspend() doesn't get called as part of phy_stop() for PHYs using
> interrupts because the phy state machine is never triggered after a phy_stop().
> 
> Explicitly trigger the PHY state machine so that it can
> see the new PHY state (HALTED) and suspend the PHY.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Hi Roger

This seems sensible. It mirrors what phy_start() does.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

It does however lead to a follow up question. Are there other places
phydev->state is changed and it is missing a phy_trigger_machine()?

	      Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts Roger Quadros <rogerq@ti.com> - 2017-03-15 15:00 +0100
  Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Andrew Lunn <andrew@lunn.ch> - 2017-03-15 15:20 +0100
    Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Roger Quadros <rogerq@ti.com> - 2017-03-15 16:10 +0100
      Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Andrew Lunn <andrew@lunn.ch> - 2017-03-15 17:00 +0100
        Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Roger Quadros <rogerq@ti.com> - 2017-03-16 11:30 +0100
          Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Florian Fainelli <f.fainelli@gmail.com> - 2017-03-20 17:50 +0100
            Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Roger Quadros <rogerq@ti.com> - 2017-03-21 11:20 +0100
              Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Florian Fainelli <f.fainelli@gmail.com> - 2017-03-21 17:20 +0100
      Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for  PHYs with interrupts Florian Fainelli <f.fainelli@gmail.com> - 2017-03-20 17:50 +0100

csiph-web