Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601345

Re: [PATCH v2 2/5] mm: parallel free pages

Show all headers | View raw

On Wed, Mar 15, 2017 at 05:42:42PM +0800, Hillf Danton wrote:
> 
> On March 15, 2017 5:00 PM Aaron Lu wrote: 
> >  void tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
> >  {
> > +	struct batch_free_struct *batch_free, *n;
> > +
> s/*n/*next/
> 
> >  	tlb_flush_mmu(tlb);
> > 
> >  	/* keep the page table cache within bounds */
> >  	check_pgt_cache();
> > 
> > +	list_for_each_entry_safe(batch_free, n, &tlb->worker_list, list) {
> > +		flush_work(&batch_free->work);
> 
> Not sure, list_del before free?

I think this is a good idea, it makes code look saner.
I just did a search of list_for_each_entry_safe and found list_del is
usually(I didn't check every one of them) used before free.

So I'll add that in the next revision, probably some days later in case
there are other comments.

Thanks for your time to review the patch.

Regards,
Aaron
 
> > +		kfree(batch_free);
> > +	}
> > +
> >  	tlb_flush_mmu_free_batches(tlb->local.next, true);
> >  	tlb->local.next = NULL;
> >  }
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-15 10:10 +0100
  [PATCH v2 2/5] mm: parallel free pages Aaron Lu <aaron.lu@intel.com> - 2017-03-15 10:10 +0100
    Re: [PATCH v2 2/5] mm: parallel free pages "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-03-15 10:50 +0100
      Re: [PATCH v2 2/5] mm: parallel free pages Aaron Lu <aaron.lu@intel.com> - 2017-03-15 13:00 +0100
  Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-15 15:30 +0100
    Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-15 16:50 +0100
      Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-15 17:30 +0100
        Re: [PATCH v2 0/5] mm: support parallel free of memory Tim Chen <tim.c.chen@linux.intel.com> - 2017-03-15 22:40 +0100
          Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-16 10:10 +0100
            Re: [PATCH v2 0/5] mm: support parallel free of memory Tim Chen <tim.c.chen@linux.intel.com> - 2017-03-16 19:40 +0100
              Re: [PATCH v2 0/5] mm: support parallel free of memory Minchan Kim <minchan@kernel.org> - 2017-03-17 09:10 +0100
              Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-17 09:30 +0100
                Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-17 13:40 +0100
                Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-17 14:00 +0100
                Re: [PATCH v2 0/5] mm: support parallel free of memory Peter Zijlstra <peterz@infradead.org> - 2017-03-17 14:20 +0100
                Re: [PATCH v2 0/5] mm: support parallel free of memory Peter Zijlstra <peterz@infradead.org> - 2017-03-17 14:00 +0100
                Re: [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko <mhocko@kernel.org> - 2017-03-17 14:30 +0100
            Re: [PATCH v2 0/5] mm: support parallel free of memory Dave Hansen <dave.hansen@intel.com> - 2017-03-21 16:10 +0100
              Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-22 09:20 +0100
              Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-24 08:10 +0100
            Re: [PATCH v2 0/5] mm: support parallel free of memory Tim Chen <tim.c.chen@linux.intel.com> - 2017-03-21 16:20 +0100
        Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-16 08:00 +0100
        Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-16 08:40 +0100
          Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-16 15:00 +0100
            Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-16 15:20 +0100
  Re: [PATCH v2 0/5] mm: support parallel free of memory Vlastimil Babka <vbabka@suse.cz> - 2017-03-15 16:00 +0100
    Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-15 17:00 +0100
    Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-17 04:20 +0100
  Re: [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu <aaron.lu@intel.com> - 2017-03-17 03:30 +0100

csiph-web