Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601237

Re: [PATCH 17/19] pinctrl: amd: make use of raw_spinlock variants

Path csiph.com!eternal-september.org!feeder.eternal-september.org!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 17/19] pinctrl: amd: make use of raw_spinlock variants
Date Wed, 15 Mar 2017 11:20:02 +0100
Message-ID <tleca-6cz-37@gated-at.bofh.it> (permalink)
References <tj9gC-7KS-21@gated-at.bofh.it> <tjaml-8rP-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aO8vrOXP63mrSekBy1GzTZkGLcBSxx/EhJGJ9u1IAk4=; b=aC+xsyW6DWR1Cb6nUTDCw9fOP2Yv3FKUZc0XWE1NhEYtDWh9l/meAAmWIIKJrvDuCF vy/fJDtxVEoAVoXcHbT1m59exWlpiJ5Ahl2tLwIxDFxsOW5XNPvDvgZVJ7zOTcSROPYg 4nC7+nmgEVZ9fnO7fQ8nE0V2fmFvqTO+k3K28=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aO8vrOXP63mrSekBy1GzTZkGLcBSxx/EhJGJ9u1IAk4=; b=Fdz6ZrVqdc72DhCnND44Mj1uE+jLQYQVUC0Zrq0vLfQ90b8cpPNFlGDIZW215l9a8K 04xhYQxzA5rdwcxudQPXyZDGmPceqeoBDF/pvv2IxOj77fmdJA/8pq1NyxO1qtT9G4o+ f8Ua+/fUTr/fY8nl/kOZgKnCVm8Xt3BLbkJrKe5tiaD/hCLTd/L5xwXgn6ptkZOuYdJt sA+RLeqouL+jwM7Fco6NxrkJeiM9ubW4RkcqlDq+3IFy737rDab6+FB8asX5b/sxX/BH oeLK/hgZ++Yi2w32bMXN8rwb1LHJpDOENuWUocDkc5Q416DSVMChL5i/CP4k3dzc1Xv7 M28A==
X-Gm-Message-State AFeK/H0potaI6/JSysJBSw+Qxa4pA6rghn/naU+G7hPPQixsTLPJlYHvWrx/oIBNq8yVkOiBCCVLjYRgbjHq+X46
X-Received by 10.107.59.74 with SMTP id i71mr4708809ioa.151.1489572758742; Wed, 15 Mar 2017 03:12:38 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 17
Organization linux.* mail to news gateway
X-Original-Cc "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
X-Original-Date Wed, 15 Mar 2017 11:12:37 +0100
X-Original-Message-ID <CACRpkdaQ8+D31EndEJfE4GOdmhe8kUL0zN8fT9yG-KEeO_1kSw@mail.gmail.com>
X-Original-References <cover.1489015238.git.julia@ni.com> <1078eff36a2507d1aa5130cc0a9b28d520aabf31.1489015238.git.julia@ni.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1601237

Show key headers only | View raw


On Thu, Mar 9, 2017 at 5:22 PM, Julia Cartwright <julia@ni.com> wrote:

> The amd pinctrl drivers currently implement an irq_chip for handling
> interrupts; due to how irq_chip handling is done, it's necessary for the
> irq_chip methods to be invoked from hardirq context, even on a a
> real-time kernel.  Because the spinlock_t type becomes a "sleeping"
> spinlock w/ RT kernels, it is not suitable to be used with irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@ni.com>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 17/19] pinctrl: amd: make use of raw_spinlock variants Linus Walleij <linus.walleij@linaro.org> - 2017-03-15 11:20 +0100

csiph-web