Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601269

[PATCH v4 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message

Show key headers only | View raw

From: Suniel Mahesh <sunil.m@techveda.org>

Fixed the following checkpatch.pl warning:
Possible unnecessary 'out of memory' message
If it is out of memory, function should return with an
appropriate error code. Since this function is of type void,
a return statement is used.

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Changes for v4:

- Modified description for better readability as pointed out by
  Dan Carpenter

Changes for v3:

- Split earlier patches into multiple commits for easy review
  as suggested by Greg K-H
- Modified subject and description for better readability
- Rebased on top of next-20170310
- Patches were tested and built on next-20170310 and staging-testing
  as suggested by Greg K-H, no errors reported

Changes for v2:

- Improve error handling reported by checkpatch.pl in rtl_core.c
- new patch addition to the series
- Rebased on top of next-20170306
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index eb2321c..37a03ca 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -971,8 +971,8 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
 
 	priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
 	if (!priv->pFirmware)
-		netdev_err(dev,
-			   "rtl8192e: Unable to allocate space for firmware\n");
+		return;
+
 	skb_queue_head_init(&priv->skb_queue);
 
 	for (i = 0; i < MAX_QUEUE_SIZE; i++)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] staging: rtl8192e: Fix coding style, warnings and checks sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 8/8] staging: rtl8192e: Fix blank lines and space after a cast sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 2/8] staging: rtl8192e: Fix coding style sunil.m@techveda.org - 2017-03-15 11:00 +0100
    Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 11:20 +0100
    Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 11:20 +0100
      Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style Suniel Mahesh <sunil.m@techveda.org> - 2017-03-15 12:20 +0100
        Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 12:20 +0100
  [PATCH v3 6/8] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces sunil.m@techveda.org - 2017-03-15 11:00 +0100
    Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 11:30 +0100
  [PATCH v3 1/8] staging: rtl8192e: Fix comments as per kernel coding style sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 7/8] staging: rtl8192e: Fix issues reported by checkpatch.pl sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 4/8] staging: rtl8192e: Rectify pointer comparisions with NULL sunil.m@techveda.org - 2017-03-15 11:00 +0100
  [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message sunil.m@techveda.org - 2017-03-15 11:00 +0100
    Re: [PATCH v3 3/8] staging: rtl8192e: Remove unnecessary 'out of  memory' message Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 11:20 +0100
      [PATCH v4 3/8] staging: rtl8192e: Remove unnecessary 'out of memory' message sunil.m@techveda.org - 2017-03-15 12:00 +0100
        Re: [PATCH v4 3/8] staging: rtl8192e: Remove unnecessary 'out of  memory' message Greg KH <gregkh@linuxfoundation.org> - 2017-03-16 03:40 +0100
          [PATCH v4 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m@techveda.org - 2017-03-16 23:30 +0100
          [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks sunil.m@techveda.org - 2017-03-16 23:30 +0100
            [PATCH v4 6/6] staging: rtl8192e: Fix blank lines and space after a cast sunil.m@techveda.org - 2017-03-16 23:30 +0100
            Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and  checks Greg KH <gregkh@linuxfoundation.org> - 2017-03-17 07:20 +0100
              [PATCH v5 2/6] staging: rtl8192e: Remove unnecessary 'out of memory' message suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
              [PATCH v5 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
              [PATCH v5 0/6] staging: rtl8192e: Fix coding style, warnings and checks suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
                [PATCH v5 6/6] staging: rtl8192e: Fix blank lines and space after a cast suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
                [PATCH v5 3/6] staging: rtl8192e: Rectify pointer comparisions with NULL suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
                [PATCH v5 1/6] staging: rtl8192e: Fix comments as per kernel coding style suniel.spartan@gmail.com - 2017-03-21 10:10 +0100
                [PATCH v5 5/6] staging: rtl8192e: Fix issues reported by checkpatch.pl suniel.spartan@gmail.com - 2017-03-21 10:10 +0100

csiph-web