Re: [PATCH 11/19] gpio: zx: make use of raw_spinlock variants

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/19] gpio: zx: make use of raw_spinlock variants
Date	Wed, 15 Mar 2017 11:10:02 +0100
Message-ID	<tle2u-689-9@gated-at.bofh.it> (permalink)
References	<tj9gC-7KS-21@gated-at.bofh.it> <tj9zX-7Tv-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PsSxW+TkDFcwnjLXx0WmNxMU7Jv+mdQrn0fUym1DZD0=; b=LeqW788S6yVSnnOGCPE9LrU6uJLVxqgGBJNXMYvCCyKC1Zm8tFObrgphnmFy/6JQoJ ulm1vugqai/Li5Ztu/Kc14Y0oRKc2B0ZrjXkri2rIu1fry+HDYR+PAXbOGDC9wKEgkpp StiBhEeKS5tfuL24IUW+s6DLYPoA65UwpYmiE=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PsSxW+TkDFcwnjLXx0WmNxMU7Jv+mdQrn0fUym1DZD0=; b=IIE8frd5OysM7BZvMENN7HPiECPNGZv4FWMB0AXJQSL33IGpg8AjLleB+gTQxaXxXl YtxMp/K5wMA2IqR1f1EasK8SWeYBbYx/Abmjgfk08p4eaMvlMpcoXR3vMPXzVUflCQt7 IpLnIwN1ZKajQ7pYicFi8xh6zJ71V0VBxtiM8QBpGi2pVxwdZllSi7xopTMo+tKBS3j5 K6dBhnkbtxxBMYf8YZxPa/EdB5f2ksZYenj//b1W1Bt45235L3QRGqScc0ac1kQi+FLA +bbXc8nU7oE1hienvqk7uqFeN23YfkEgGp/YYzRbRwpe91yJqzKlqwaeNtEqMSEkpwfi 1pFg==
X-Gm-Message-State	AFeK/H22Smz/YJoRM4xEuGDqn7ozai3Z6n08X0x1P37TMU9x1PICwCtReywl70PEbojxnQMLEgZNav5xnbcX3A4D
X-Received	by 10.107.20.193 with SMTP id 184mr3980039iou.61.1489572224618; Wed, 15 Mar 2017 03:03:44 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	Alexandre Courbot <gnurou@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
X-Original-Date	Wed, 15 Mar 2017 11:03:43 +0100
X-Original-Message-ID	<CACRpkdZKx3L+tLxq5-WcyJOobHKo8uvDfMCu9d3if1Uyyfti2w@mail.gmail.com>
X-Original-References	<cover.1489015238.git.julia@ni.com> <5198486738fd89f8187b911256ddd3f09a7f9188.1489015238.git.julia@ni.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601213

Show key headers only | View raw

On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright <julia@ni.com> wrote:

> The zx gpio driver currently implements an irq_chip for handling
> interrupts; due to how irq_chip handling is done, it's necessary for the
> irq_chip methods to be invoked from hardirq context, even on a a
> real-time kernel.  Because the spinlock_t type becomes a "sleeping"
> spinlock w/ RT kernels, it is not suitable to be used with irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@ni.com>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 11/19] gpio: zx: make use of raw_spinlock variants Linus Walleij <linus.walleij@linaro.org> - 2017-03-15 11:10 +0100

csiph-web