Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601220

Re: [PATCH 09/19] gpio: pl061: make use of raw_spinlock variants

Path csiph.com!goblin3!goblin1!goblin.stu.neva.ru!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 09/19] gpio: pl061: make use of raw_spinlock variants
Date Wed, 15 Mar 2017 11:10:02 +0100
Message-ID <tle2u-689-19@gated-at.bofh.it> (permalink)
References <tj9gC-7KS-21@gated-at.bofh.it> <tj9Tj-8fj-7@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cfpuNWEF3egbUlMTupw90EPMk9p6spfzKIyxbx5GSEQ=; b=ISottHQT5RpMBuKamjm3qG1N7FTLFpL2QpEf8H8FwKSpqFqDDoUzFnAB53uIl3wwm8 BPsPeJMRYfhRJ78BXiVxMoy/NKnT/vj01B0iMBIJdib7skrkZVp5o/nsBK+lY27N7r1I 54fUmoxychz5XC9XowjmbawFJ8d3pydOJU+zU=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cfpuNWEF3egbUlMTupw90EPMk9p6spfzKIyxbx5GSEQ=; b=ZQnTF5E5ZiqtyhRfnA0ybfzPnG/QoJaJoTU9sgNckXJVEm/Rx2fQO8slzwMdTP6906 EXVTFoA8C9iThXsUEouAh/VGXTL55/pt2RZ7LY1BH+z1NzgqsnORUniwWz7O9Hw2f6S6 7d827qbhlu8uSyt0SYhHLk9g6w4grHrbd7k0jscKnRgM0m2TydhYWdU5s37lAt6WzY0R T7btHWpcKrjSiyURSBLvJzs0Ac9S9e0khlM9+fFVEATWxbaNldbveUcv/z5/osOhQ4JR Rwr/0XFjxYPiHN7NuM/3iMCMyT9FmEQVzcnkZNtUWp3qCMK0obeYfRPStQtEzYGrQ9qX iNhw==
X-Gm-Message-State AFeK/H3UcRTCIqptmLYzMGEnAWZKvYbwaQkrQoZDqFriTih7UQgpeyEfdB61at/Ot9loyG/PtMdgoe+/BU6YkYPf
X-Received by 10.107.146.198 with SMTP id u189mr4488816iod.173.1489572084029; Wed, 15 Mar 2017 03:01:24 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 17
Organization linux.* mail to news gateway
X-Original-Cc Alexandre Courbot <gnurou@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
X-Original-Date Wed, 15 Mar 2017 11:01:23 +0100
X-Original-Message-ID <CACRpkdZvHGgbywdFqQjhv4uu4PYw4AKVw7a+D3veoxOZGCReXQ@mail.gmail.com>
X-Original-References <cover.1489015238.git.julia@ni.com> <393599ef5e6ee95b6d143f56c4be47a21599b7b5.1489015238.git.julia@ni.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1601220

Show key headers only | View raw


On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright <julia@ni.com> wrote:

> The pl061 gpio driver currently implements an irq_chip for handling
> interrupts; due to how irq_chip handling is done, it's necessary for the
> irq_chip methods to be invoked from hardirq context, even on a a
> real-time kernel.  Because the spinlock_t type becomes a "sleeping"
> spinlock w/ RT kernels, it is not suitable to be used with irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@ni.com>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 09/19] gpio: pl061: make use of raw_spinlock variants Linus Walleij <linus.walleij@linaro.org> - 2017-03-15 11:10 +0100

csiph-web