Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601146

RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

From David Laight <David.Laight@ACULAB.COM>
Newsgroups linux.kernel
Subject RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets
Date 2017-03-15 10:00 +0100
Message-ID <tlcWJ-5bE-3@gated-at.bofh.it> (permalink)
References <tkYAp-3tR-7@gated-at.bofh.it> <tkYAq-3tR-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Shannon Nelson
> Sent: 14 March 2017 17:25
...
> +	if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest)))
> +		dev->stats.multicast++;

I'd guess that:
	dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_dest);
generates faster code.
Especially if is_multicast_ether_addr(x) is (*x >> 7).

	David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 net-next 4/5] sunvnet: count multicast packets Shannon Nelson <shannon.nelson@oracle.com> - 2017-03-14 18:40 +0100
  RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets David Laight <David.Laight@ACULAB.COM> - 2017-03-15 10:00 +0100
    Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets Shannon Nelson <shannon.nelson@oracle.com> - 2017-03-16 01:20 +0100
      RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets David Laight <David.Laight@ACULAB.COM> - 2017-03-16 13:20 +0100
        Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets David Miller <davem@davemloft.net> - 2017-03-16 19:40 +0100

csiph-web