Re: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings.
Date	2017-03-15 09:40 +0100
Message-ID	<tlcDo-530-3@gated-at.bofh.it> (permalink)
References	<tl8gp-1Mz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix the subject.  The subsystem prefix is wrong and it's too vague.
Change it to:

[PATCH] Staging: goldfish: use __func__ instead of embedded function names

On Tue, Mar 14, 2017 at 08:53:50PM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming.  Prefer the use
> of "%s", __func__ to embedded function names
> 
> Signed-off-by: mshan <mohsinshan1k@gmail.com>

Please use your legal/formal name as if you were signing a legal
document.  Also change the From header on your email to match.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings. mshan <educha997@gmail.com> - 2017-03-15 05:00 +0100
  Re: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding  style Warnings. Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-15 09:40 +0100

csiph-web